[8.0][ADD][website_event_multi_image] Public image gallery in events

[yajo]

This will fail until OCA/server-tools#374
and #31 get merged.

This module takes functionalities from above ones and displays them in
the website part of events.

See readme for more details.

@rafaelbn

[dreispt]

Let's wait on the upstream PR.

[yajo]

Please remove WIP label, upstream modules are merged now.

I rebased to see if I get 💚

[dreispt]

👍

[pedrobaeza]

I have tried the module in runbot, and I have some comments:

• Image gallery appears on the bottom of the event. It makes that you need to scroll all the event description to see the image gallery. Can it appear at the top? Or maybe on the side?
• I have added some small images and non-squared images:

In the website image gallery, they appear cropped and very big:

Is there the possibility to have another layout?

• Another useful snippet/template is to have the usual small layout previewing all the images that you expand in the big box when clicking on it. Is it very complicated to implement on website_multi_image?

[andhit-r]

Tested on runbot 👍 . @pedrobaeza layout idea is nice to have though. But for now i'm good with current layout. Just put it on top of the page, bellow sales table

[yajo]

Hi @pedrobaeza:

Image gallery appears on the bottom of the event. It makes that you need to scroll all the event description to see the image gallery. Can it appear at the top? Or maybe on the side?

Fixed.

I have added some small images and non-squared images:
In the website image gallery, they appear cropped and very big:

This is by design. Image galleries are mostly designed for big-size high-quality pics. They are autocropped to achieve a consistent layout, and to avoid forcing the user to set a specific image size.

This is done by website_multi_image, and you can change behavior with themes if your specific website desires to display icons in the event slideshow.

Another useful snippet/template is to have the usual small layout previewing all the images that you expand in the big box when clicking on it. Is it very complicated to implement on website_multi_image?

This comes out of the box in Odoo 9, so it will be much easier there. I prefer to wait for migrating to target that.

[pedrobaeza]

OK, then 👍

[rafaelbn]

Travis fails

[rafaelbn]

cc @antespi

[rafaelbn]

Please @yajo check travis. Fixing travis we can merge this. Thanks

cc @pedrobaeza

[rafaelbn]

As said, functionally 👍 but check travis before merging

[dreispt]

There is a problem from the openerp.addons.website.tests.test_crawl test...

[yajo]

Thanks @dreispt, it seems a permissions issue. I have to add an ACL that allows public users to read images from published events. Does anybody know how to do such thing? I think it is better than adding .sudo() to the controller.

[dreispt]

Maybe @hbrunn can suggest something.

[hbrunn]

the ACL seems the way to go. And probably an ir.rule to restrict the public user to indeed only read published images

[coveralls]

Coverage decreased (-0.5%) to 87.863% when pulling 49ab4f6 on Yajo:multi-image-website into e55862b on OCA:8.0.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.