Skip to content

[14.0] base_import_async: add a dedicated channel - #449

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
camptocamp:14.0-base_import_async-add-channel
Nov 22, 2022
Merged

[14.0] base_import_async: add a dedicated channel#449
OCA-git-bot merged 1 commit into
OCA:14.0from
camptocamp:14.0-base_import_async-add-channel

Conversation

@sebalix

@sebalixsebalix commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

So we can configure the size of the channel.

We experienced a lot of locks and concurrent update issues on a table because tens of jobs were running in parallel (root is set with a high value).

simahawk
simahawk reviewed Aug 1, 2022
View reviewed changes
Comment threadbase_import_async/data/queue_job_function_data.xml
<record id="job_function_base_import_import_split_file" model="queue.job.function">
<field name="model_id" ref="base_import.model_base_import_import" />
<field name="method">_split_file</field>
<field name="channel_id" ref="channel_base_import" />

@simahawksimahawkAug 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make these changes effective we need a migration step IMO

@guewenguewenAug 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be changed by users, could be good to have a migration (only if no other channel than root was configured manually), but is not strictly required IMO

@OCA-git-bot

OCA-git-bot commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon

lmignon commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-449-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit c5f3c40 into OCA:14.0Nov 22, 2022
@OCA-git-bot

OCA-git-bot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 8a43fe6. Thanks a lot for contributing to OCA. ❤️

This was referenced Dec 27, 2024
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawksimahawksimahawk left review comments
@guewenguewenguewen approved these changes
@lmignonlmignonlmignon approved these changes
@sbidoulsbidoulsbidoul approved these changes

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sebalix@OCA-git-bot@lmignon@simahawk@guewen@sbidoul