[16.0][UPD] Forward port changes from 14.0 and 15.0 by florentx · Pull Request #729 · OCA/queue

florentx · 2024-12-27T09:37:26Z

Following PRs were missing in 16.0 branch. They are now forward ported from 14.0 and 15.0 branches:

OCA-git-bot · 2024-12-27T09:37:30Z

Hi @guewen,
some modules you are maintaining are being modified, check this out!

As normal user only have read access to delay.export, we need sudo to chreate an attachment on this record Use user 6 (Marc Demo) in the tests, not admin (2)

Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

* use FIFO, firt createad job will be treat first * if priority are different it take the precedent Yet we are not using channel priority into account

sebalix · 2025-01-13T11:07:47Z

You squashed commits from this PR into one: https://github.com/OCA/queue/pull/676/commits
History has to be preserved

sebalix

One comment, LG othrewise

- an explicit flush is needed or child jobs won't be updated - no need to forward port, this was fixed already in 16.0+

Otherwise, you cannot use any channel other than default ( root.ir_cron)

florentx · 2025-01-13T12:15:55Z

I've re-based to preserve history here.
Fixes also s/flush/flush_model/

sebalix · 2025-01-13T12:57:41Z

@florentx the flush call is still in ff52b57 while it should be in dbe64b9

florentx · 2025-01-13T13:31:15Z

@florentx the flush call is still in ff52b57 while it should be in dbe64b9

I disagree, the flush was on the 2nd commit: 189a30761#diff-52052ee7edd7df6a68c13f1c6f9667c1556c7c08b0a8e91de76dcd7b2d604439R319

I preserved it.

The other flush in condition if state == DONE: was already present in branch 16.

EDIT: was also mentioned in comment on the PR that it pre-existed in 16: #676 (comment)

sebalix · 2025-01-13T13:40:24Z

You are right, I misread the line, there is another flush call in the same method but regarding state == DONE, this one is already present in 16.0 👍

simahawk · 2025-01-28T10:46:30Z

/ocabot merge minor

OCA-git-bot · 2025-01-28T10:46:36Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-729-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot · 2025-01-28T10:50:51Z

Congratulations, your PR was merged at f61bf60. Thanks a lot for contributing to OCA. ❤️

base_import_async: add a dedicated channel
58fb14a

sbidouland others added 3 commits December 27, 2024 13:47

Update test with proper way to pass company to job
2356167

[FIX] Access error on ir.attachment create
56fdd3e
As normal user only have read access to delay.export, we need sudo to chreate an attachment on this record Use user 6 (Marc Demo) in the tests, not admin (2)

queue_job: fix retry format with tuple values
4ccc68e
Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

florentx force-pushed the 16.0_port branch from c8ca460 to bad0d05Compare December 27, 2024 12:55

florentx changed the title ~~[16.0][UPD] Forward port changes from 14.0~~[16.0][UPD] Forward port changes from 14.0 and 15.0Dec 27, 2024

florentx force-pushed the 16.0_port branch from bad0d05 to 23fc991Compare December 27, 2024 13:03

[FIX] queue_job_cron_jobrunner: use priority to select job
ca2a8c7
* use FIFO, firt createad job will be treat first * if priority are different it take the precedent Yet we are not using channel priority into account

florentx force-pushed the 16.0_port branch from 1ddee9a to 3cff8abCompare December 27, 2024 16:37

florentx mentioned this pull request Jan 13, 2025
[16.0][FW] queue_job: multiple ports from 14.0 #736
Closed

sebalix reviewed Jan 13, 2025
View reviewed changes

florentx force-pushed the 16.0_port branch 2 times, most recently from 2ebafe9 to 81ff27cCompare January 13, 2025 11:32

QuocDuong1306and others added 7 commits January 13, 2025 12:44

[FIX] queue_job: missing flush
dbe64b9
- an explicit flush is needed or child jobs won't be updated - no need to forward port, this was fixed already in 16.0+

[IMP] queue_job: Cancel child jobs when the parent is cancelled
ff52b57

[FIX] queue_job: typo
6d1b1cb

[IMP] queue_job: add filter on Date Created
d5b6903

[REF] remove explicit 'object' inheritance
a7431d5

[REF] remove explicit super() arguments
4ae757c

[13.0][FIX] queue_job_cron: channel_id must be storable.
10f7161
Otherwise, you cannot use any channel other than default ( root.ir_cron)

florentx force-pushed the 16.0_port branch from 81ff27c to 10f7161Compare January 13, 2025 11:46

sebalix approved these changes Jan 13, 2025
View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 28, 2025

OCA-git-bot merged commit 58fded3 into OCA:16.0Jan 28, 2025

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 28, 2025

florentx deleted the 16.0_port branch May 8, 2025 11:40

Navigation Menu

Uh oh!

Uh oh!

[16.0][UPD] Forward port changes from 14.0 and 15.0 - #729

[16.0][UPD] Forward port changes from 14.0 and 15.0#729
OCA-git-bot merged 12 commits into
OCA:16.0from
florentx:16.0_port

florentx commented Dec 27, 2024•
edited
Loading

Uh oh!

OCA-git-bot commented Dec 27, 2024

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

sebalix left a comment

Uh oh!

florentx commented Jan 13, 2025

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

florentx commented Jan 13, 2025•
edited
Loading

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

simahawk commented Jan 28, 2025

Uh oh!

OCA-git-bot commented Jan 28, 2025

Uh oh!

OCA-git-bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

florentx commented Dec 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Dec 27, 2024

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

sebalix left a comment

Choose a reason for hiding this comment

Uh oh!

florentx commented Jan 13, 2025

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

florentx commented Jan 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebalix commented Jan 13, 2025

Uh oh!

simahawk commented Jan 28, 2025

Uh oh!

OCA-git-bot commented Jan 28, 2025

Uh oh!

OCA-git-bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

florentx commented Dec 27, 2024•
edited
Loading

florentx commented Jan 13, 2025•
edited
Loading