Uh oh!
There was an error while loading. Please reload this page.
[14.0] queue_job: triggers stored computed fields before calling 'set_done()' - #637
Merged
Merged
Conversation
So the time required to compute such fields by the ORM is taken into account when the 'date_done' and 'exec_time' values are set on the job.
OCA-git-bot
commented
Mar 27, 2024
Contributor
Hi @guewen, |
simahawk
commented
Mar 27, 2024
Contributor
/ocabot merge patch |
OCA-git-bot
commented
Mar 27, 2024
Contributor
On my way to merge this fine PR! |
simahawk
commented
Mar 27, 2024
Contributor
Can you fwd port pls? 👼 |
OCA-git-bot
commented
Mar 27, 2024
Contributor
Congratulations, your PR was merged at 50795d1. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Mar 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the time required to compute such fields by the ORM is taken into account when the
date_doneandexec_timevalues are set on the job.Before: the execution time was reporting only the time taken by the delayed method itself. Time needed for stored computed fields triggered by the call to
flush()wasn't included.After: take into account all the time (delayed method + extra work of the ORM) in the execution time.
Without this change, the execution time is misleading and doesn't help to know if a job is (or became) slow.
cc @simahawk