Skip to content

[17.0][UPD] Forward port changes from 14/15/16 - #731

Merged
OCA-git-bot merged 14 commits into
OCA:17.0from
florentx:17.0_port
Jun 6, 2025
Merged

[17.0][UPD] Forward port changes from 14/15/16#731
OCA-git-bot merged 14 commits into
OCA:17.0from
florentx:17.0_port

Conversation

@florentx

@florentxflorentx commented Dec 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Following PRs were missing in 17.0 branch. They are now forward ported from earlier branches (14, 15 and 16):

@OCA-git-bot

OCA-git-bot commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Hi @guewen, @ivantodorovich,
some modules you are maintaining are being modified, check this out!

@florentx
florentxforce-pushed the 17.0_port branch 5 times, most recently from 9463909 to 2b0c033CompareDecember 27, 2024 17:04
@hbrunn

hbrunn commented Mar 21, 2025

Copy link
Copy Markdown
Member

@florentx please fix conflicts

@florentx

florentx commented Mar 21, 2025

Copy link
Copy Markdown
ContributorAuthor

@florentx please fix conflicts

Done. Thank you.

@ecino

ecino commented May 8, 2025

Copy link
Copy Markdown

There are again some conflicts on this, but the changes would be appreciated!

sbidouland others added 14 commits May 8, 2025 12:47
@sbidoul@florentx
Update test with proper way to pass company to job
ea2e952
@MiquelRForgeFlow@florentx
[IMP] queue_job: track error in chatter
a428dff
@lmignon@florentx
[IMP] queue_job_cron: Avoid parallel run
02c52b6
By default, odoo never runs the same cron job in parallel. This commit uses the identity key mechanism to enforce this mechanism when a cron job is run as a queue job. This behaviour can be controlled by a new setting on the cron definition but is activated by default to keep the original behaviour
@InigoGR@florentx
queue_job: fix retry format with tuple values
1b78f43
Configuration of randomized retry intervals is not possible due to the formatting checks not being updated.
This should fix it.
Sébastien Alix@florentx
queue_job: fix partial index to add 'wait_dependencies' state
6b95faa
Sébastien Alix@florentx
queue_job: triggers stored computed fields before calling 'set_done()'
3ee1f0c
So the time required to compute such fields by the ORM is taken into
account when the 'date_done' and 'exec_time' values are set on the job.
Sébastien Alix@florentx
queue_job: fix warning when triggering stored computed fields
100d58e
Starting from 16.0, we should call `env.flush_all()` instead of
`env["base"].flush()`, like it is done few lines below.
@petrus-v@florentx
[FIX] queue_job_cron_jobrunner: use priority to select job
f8fcceb
* use FIFO, firt createad job will be treat first
* if priority are different it take the precedent
Yet we are not using channel priority into account
@paradoxxxzero@florentx
[IMP] queue_job: Add split method
95ce35a
@QuocDuong1306@florentx
[IMP] queue_job: Cancel child jobs when the parent is cancelled
74ed19f
@florentx
[FIX] queue_job: typo
eab6121
@florentx
[IMP] queue_job: add filter on Date Created
4bf003a
@florentx
[REF] remove explicit super() arguments
9dd9d19
@LoisRForgeFlow@florentx
[FIX] queue_job_cron: channel_id must be storable.
7995de8
Otherwise, you cannot use any channel other than default (
root.ir_cron)
@florentxflorentx mentioned this pull request May 8, 2025
Closed
@ecino

ecino commented Jun 3, 2025

Copy link
Copy Markdown

Can we merge?

@florentx

florentx commented Jun 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Yes, this PR is 5 months old, and it is only port of changes from other branches. It needs someone with write access to merge it.

@sbidoul ? @rvalyi ?

@rvalyi

rvalyi commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@florentx I use queue modules in many projects. But I don't claim to master it enough to assume merging such large changes in my name. I'm an historical "core committer", but I only merge things I'm very sure about to avoid doing any harm.

In my opinion it would make more sense you propose yourself as a project PSC and get the commit rights granted. May be other PSCs will not agree but I think you have enough skills and responsabiltities to step in.

You could make a PR here to apply:
https://github.com/OCA/repo-maintainer-conf

@hbrunn

hbrunn commented Jun 6, 2025

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-731-by-hbrunn-bump-minor, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d512a58. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
OCA-git-bot merged commit afae818 into OCA:17.0Jun 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbrunnhbrunnhbrunn approved these changes
+1 more reviewer
@ecinoecinoecino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@florentx@OCA-git-bot@hbrunn@ecino@rvalyi@sbidoul@MiquelRForgeFlow@lmignon@InigoGR@petrus-v@paradoxxxzero@QuocDuong1306@LoisRForgeFlow