[IMP] use PyPDF2 if possible - #141
Merged
Merged
Conversation
Member
|
Now we have broken tests. Can you please check? |
hbrunn
force-pushed
the
9.0-report_qweb_pdf_watermark
branch
from
July 18, 2017 07:20
1e0dcf8 to
c434353
Compare
@hbrunn - You're looking for |
elicoidal
reviewed
Aug 29, 2017
| pdf = PdfFileWriter() | ||
| pdf_watermark = None | ||
| try: | ||
| print 'read watermark' |
There was a problem hiding this comment.
Shouldnot we remove all print statements?
hbrunn
force-pushed
the
9.0-report_qweb_pdf_watermark
branch
from
August 30, 2017 08:01
20f68ab to
9e4725b
Compare
This was referenced Aug 30, 2017
Member
Author
|
@elicoidal sure, those were just for debugging why the build wouldn't work on travis and yay, it's green, can we merge? |
Member
|
Please change module version number |
hbrunn
force-pushed
the
9.0-report_qweb_pdf_watermark
branch
from
August 30, 2017 08:18
9e4725b to
c0252f7
Compare
Member
Author
|
done |
pedrobaeza
approved these changes
Aug 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypdf is very slow for merging pages, with PyPDF2, we get something between 20-80% speedup according to my tests