[9.0][FIX] report_qweb_pdf_watermark - #154
Closed
MiquelRForgeFlow wants to merge 4 commits into
Closed
MiquelRForgeFlow wants to merge 4 commits into
MiquelRForgeFlow wants to merge 4 commits into
Conversation
astirpe
suggested changes
Jul 28, 2017
| from base64 import b64decode | ||
| from logging import getLogger | ||
| from pyPdf import PdfFileWriter, PdfFileReader | ||
| from pyPdf.pdf import PdfFileWriter, PdfFileReader |
Contributor
Author
There was a problem hiding this comment.
Because otherwise my PyCharm says 'unresolved reference...' 😙
Contributor
|
|
Member
|
Can you try to backport the entire commit 7d62102? I mean deleting also the obsolete rows in I'm not sure this will fix the problem though. |
Contributor
Author
|
I fully backported the two commits of that PR but both squashed into one. |
Member
|
@mreficient it seems you missed a commit. Can you double check? Take a look at the commit mentioned in my previous post and then look at your commits. |
Contributor
Author
Merged
Member
|
this finally is fixed in #141 by now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #144.