Skip to content

[FIX] bi_sql_editor: solves the update all break - #269

Merged
JordiBForgeFlow merged 1 commit into
OCA:11.0from
ForgeFlow:11.0-fix-bi_sql_editor-readme
Jan 16, 2019
Merged

JordiBForgeFlow merged 1 commit into
OCA:11.0from
ForgeFlow:11.0-fix-bi_sql_editor-readme

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

This PR updates the readme of bi_sql_editor to inform how to solve the update all break.

@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 11.0-fix-bi_sql_editor-readme branch 3 times, most recently from 1cd1eed to edeab0c Compare January 15, 2019 18:56
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 11.0-fix-bi_sql_editor-readme branch from edeab0c to be45a95 Compare January 15, 2019 19:06
@MiquelRForgeFlow MiquelRForgeFlow changed the title [FIX] bi_sql_editor: two ways to solve the update all break [FIX] bi_sql_editor: solves the update all break Jan 15, 2019

@HviorForgeFlow HviorForgeFlow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JordiBForgeFlow JordiBForgeFlow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a broken environment, and fixes the issue. Works like a charm!

@JordiBForgeFlow
JordiBForgeFlow merged commit 9f55a08 into OCA:11.0 Jan 16, 2019
@LoisRForgeFlow
LoisRForgeFlow deleted the 11.0-fix-bi_sql_editor-readme branch January 16, 2019 09:05
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

NOTE: For reference, added here the error that this PR solves.

Selection_632
in #264 (comment)

@legalsylvain

Copy link
Copy Markdown
Contributor

Hum. Thanks for the comment.

My question is : I use this module since years (version 8 and 12), and I realize update all each month. I never faced that issue.
Do you know in which context ?

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

I don't remember. Perhaps it has to do if you have bi sql views for materialized views, not sure. @HviorForgeFlow do you remember?

@legalsylvain

Copy link
Copy Markdown
Contributor

(I only use materialized views).

@legalsylvain

Copy link
Copy Markdown
Contributor

Well, I removed that comment in #670 as it seems to work. If there is a problem, we could always add it again, with a more detailled text of what the --load solves.

thanks for your answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants