[15.0][MIG] bi_sql_editor by mariadforgeflow · Pull Request #557 · OCA/reporting-engine

mariadforgeflow · 2021-12-13T08:25:15Z

Standard migration to v15
@ForgeFlow

…ield; [ADD] security

…fresh date time on the action name of each sql materialized view

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name

[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/

Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/

Fixes OCA#309

legalsylvain

thanks.

legalsylvain · 2021-12-15T10:16:04Z

@mariadforgeflow. I'd like to introduce some changes / improvement / refactoring on that module.

What do you prefer. do you want I make PR against your PR, or do you prefer we merge the current one, and then I propose improvment ?

thanks.

mariadforgeflow · 2021-12-15T11:06:22Z

@legalsylvain if you want to add some improvements I think it makes more sense if we first merge this PR and then you create a new [IMP] PR. So I think we could merge this one if it's okay for you:)

legalsylvain · 2021-12-15T11:45:46Z

Ok ! I'll ping you for the review.
Note :

some improvment will requires to update the installed modules.
I dont' have right to merge this PR.

AaronHForgeFlow

👍 runbotat tests

BernatPForgeFlow

LGTM!

yankinmax · 2022-01-24T09:43:04Z

@mariadforgeflow Is it ready to be merged? Can I help?

mariadforgeflow · 2022-01-24T14:45:33Z

@yankinmax yes it is ready!
@pedrobaeza Hi! Could you please merge this? Thank you in advance.

pedrobaeza · 2022-01-24T14:47:06Z

OK, merging trusting in the reviewers:

/ocabot migration bi_sql_editor
/ocabot merge nobump

OCA-git-bot · 2022-01-24T14:47:20Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-557-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-01-24T14:51:27Z

Congratulations, your PR was merged at 6863669. Thanks a lot for contributing to OCA. ❤️

CasVissers-360ERP · 2022-02-01T07:06:19Z

@mariadforgeflow
I think you made a typo while migrating the module:
index_name = fields.Char(ompute="_compute_index_name")

mariadforgeflow · 2022-02-01T07:51:31Z

@CasVissers-360ERP thanks!! Fixed in #583.

legalsylvain · 2022-10-26T12:10:13Z

Hi @mariadforgeflow. I'm currently migrating bi_sql_editor in V16. (see : #670)

I don't understand why you introduced that text in V15 :

* You must put this module as `server_wide_modules` in your odoo configuration file
  or add '--load=bi_sql_editor' if you start odoo in command line.

could you provide precision ? At my side, I never set that settings and it works.

thanks !

mariadforgeflow · 2022-10-26T13:03:14Z

Hi @legalsylvain! I didn't introduce this text, it was already there in v14 when I migrated the module.
I checked and it was added here: bf96a35

I never start odoo in command line so I don't know about this, sorry.

legalsylvain · 2022-10-26T13:06:56Z

Thanks for your answer. @davejames : could you help me on that topic ?

(Ref : #518)

thanks !

davejames · 2022-10-26T13:24:43Z

@legalsylvain i'm not sure, this was only committed by me during the migration, originally this was authored by @MiquelRForgeFlow

legalsylvain · 2022-10-26T13:31:02Z

;-) !
OK ! @MiquelRForgeFlow : any idea ?

MiquelRForgeFlow · 2022-10-26T13:43:12Z

@legalsylvain was added in #269 (see #269 (comment)).

legalsylvain and others added 30 commits December 13, 2021 08:55

new module bi_sql_editor [IMP] function to guess model for many2one f…

26ab5fd

…ield; [ADD] security

OCA Transbot updated translations from Transifex

46e4502

bi_sql_editor

4eaaff6

create ui now create tree view [IMP] fr translation [IMP] add last re…

d1bf297

…fresh date time on the action name of each sql materialized view

[IMP] Add test + several fixes

f2ef2fc

OCA Transbot updated translations from Transifex

93ac81f

FIX bi_sql_editor

1e1ebdd

[MIG] bi_sql_editor v10

1ce6fb7

[IMP] preview button

4a2fba7

Fix several issues

d09e467

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

[UPD] Update bi_sql_editor.pot

514354a

[MIG] bi_sql_editor: Migration to 11.0

cadfe4e

[FIX] Can be upgraded with materialized views generated

a673db5

[FIX] ir.cron relation

3403352

[IMP] remove unneeded parenthesis

2c863b0

[FIX] Solves the upgrading problem

a427430

[FIX] Query and technical name should only be modifiable in draft mode

4fb3e99

[UPD] Update bi_sql_editor.pot

6a0d558

[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot

Update translation files

7352c89

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[12.0][MIG] Migrate module bi_sql_editor to v12

ef1d7ac

[FIX] bi_sql_editor: add in readme how to solve the update all break

02ff134

Update readme

738c6f6

bi_sql_editor 12.0.1.2.0

47f8ccb

bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst

Translated using Weblate (German)

2b92898

Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/

[FIX] bi_sql_editor: Fixes images path

74ba16e

Fixes OCA#309

[FIX] bi_sql_editor: Add required attribute name on filters

b877f03

change SQL mapping for date

a5cccb9

[ADD] action context

8f1ba92

legalsylvain approved these changes Dec 13, 2021

View reviewed changes

legalsylvain mentioned this pull request Dec 17, 2021

[IMP][12.0] bi_sql_editor : use ace widget #567

Merged

[MIG] bi_sql_editor: Migration to 15.0

8fa79a2

mariadforgeflow force-pushed the 15-mig-bi_sql_editor branch from b5cffa6 to 8fa79a2 Compare December 17, 2021 09:43

AaronHForgeFlow approved these changes Jan 12, 2022

View reviewed changes

OCA-git-bot added the approved label Jan 12, 2022

BernatPForgeFlow approved these changes Jan 13, 2022

View reviewed changes

OCA-git-bot added this to the 15.0 milestone Jan 24, 2022

OCA-git-bot mentioned this pull request Jan 24, 2022

Migration to version 15.0 #545

Closed

20 tasks

OCA-git-bot added the bot is merging ⏳ label Jan 24, 2022

OCA-git-bot merged commit 9737a60 into OCA:15.0 Jan 24, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 24, 2022

mariadforgeflow deleted the 15-mig-bi_sql_editor branch February 1, 2022 07:47

Uh oh!

Uh oh!

Conversation

mariadforgeflow commented Dec 13, 2021

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

legalsylvain commented Dec 15, 2021

Uh oh!

mariadforgeflow commented Dec 15, 2021

Uh oh!

legalsylvain commented Dec 15, 2021

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

BernatPForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Jan 24, 2022

Uh oh!

mariadforgeflow commented Jan 24, 2022

Uh oh!

pedrobaeza commented Jan 24, 2022

Uh oh!

OCA-git-bot commented Jan 24, 2022

Uh oh!

OCA-git-bot commented Jan 24, 2022

Uh oh!

CasVissers-360ERP commented Feb 1, 2022

Uh oh!

mariadforgeflow commented Feb 1, 2022

Uh oh!

legalsylvain commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariadforgeflow commented Oct 26, 2022

Uh oh!

legalsylvain commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davejames commented Oct 26, 2022

Uh oh!

legalsylvain commented Oct 26, 2022

Uh oh!

MiquelRForgeFlow commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

legalsylvain commented Oct 26, 2022 •

edited

Loading

legalsylvain commented Oct 26, 2022 •

edited

Loading

MiquelRForgeFlow commented Oct 26, 2022 •

edited

Loading