[MIG][11.0] report_py3o backport of v12 by tbaden · Pull Request #285 · OCA/reporting-engine

tbaden · 2019-05-01T19:46:54Z

No description provided.

… the server

Replace README.md by README.rst (not finished)

Remove <data> in views Protect import of py3o libs Remove dep on base module Other small changes

Rename __openerp__.py to __manifest__.py

…ame extension

lang_code is already supported by o_format_date

Co-Authored-By: lmignon <laurent.mignon@acsone.eu>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_py3o/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_py3o_fusion_server Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_py3o_fusion_server/

lmignon · 2019-05-02T07:35:38Z

@tbaden Thank you for taking care of this backport. Can I ask you to preserve the commit history and authorship of changes when backporting the addons from Odoo 12.
Here it's a technical method to backport the addons from 12.0...

On a shell command:

$ git clone https://github.com/OCA/reporting-engine -b 11.0
$ git checkout -b 11.0-mig-reporting-engine origin/11.0
$ git format-patch --keep-subject --stdout origin/11.0..origin/12.0 -- report_py3o report_py3o_fusion_server | git am -3 --keep

Adapt the module to the 11.0 version.
On a shell command:

$ git add --all
$ git commit -m "[MIG] $MODULE: Migration to 11.0"
$ git remote add $USER_ORG git@github.com:$USER_ORG/$REPO.git # This mode requires an SSH key in the GitHub account
$ ... or ....
$ git remote add $USER_ORG https://github.com/$USER_ORG/$REPO.git # This will required to enter user/password each time
$ git push $USER_ORG 11.0-mig-$MODULE --set-upstream

(same method as for normal migration process but adapted to takes the 12.0 branch as source. This method also takes care to migrate report_py3o and report_py3o_fusion_server at same time. https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0#technical-method-to-migrate-a-module-from-110-to-120-branch)

tbaden · 2019-05-02T08:10:25Z

@lmignon I'll take care of this.

lmignon · 2019-05-02T08:14:30Z

@lmignon I'll take care of this.

Thank you to you for this work 😏

tbaden · 2019-05-02T16:02:53Z

@lmignon maybe you can give me a hint. I got all tests on green now except for test_reports_merge_zip.

getting the error:
:1: in <Expression '__py3o_frame(b64decode(objects.image), 'png', width='2cm', height='2cm', origin_attrib={'{urn:oasis:names:tc:opendocument:xmlns:text:1.0}anchor-type': 'paragraph', '{urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0}width': '0.7902in', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}name': "py3o.image(b64decode(objects.image), 'png', width='2cm', height='2cm')", '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}style-name': 'fr1', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}z-index': '0'})'>
???
/usr/lib/python3.5/base64.py:81: in b64decode
s = _bytes_from_decode_data(s)

TypeError: argument should be a bytes-like object or ASCII string, not 'bool'

If you need it, I can push my current code to github.

oca-clabot · 2019-05-02T20:33:36Z

Hey @tbaden, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Jonathan Nemry (ACSONE) jonathan.nemry@acsone.eu (no github login found)
root root@odoo11.local (no github login found)

Appreciation of efforts,
OCA CLAbot

lmignon · 2019-05-03T06:28:31Z

@lmignon maybe you can give me a hint. I got all tests on green now except for test_reports_merge_zip.

getting the error:
:1: in <Expression '__py3o_frame(b64decode(objects.image), 'png', width='2cm', height='2cm', origin_attrib={'{urn:oasis:names:tc:opendocument:xmlns:text:1.0}anchor-type': 'paragraph', '{urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0}width': '0.7902in', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}name': "py3o.image(b64decode(objects.image), 'png', width='2cm', height='2cm')", '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}style-name': 'fr1', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}z-index': '0'})'>
???
/usr/lib/python3.5/base64.py:81: in b64decode
s = _bytes_from_decode_data(s)

TypeError: argument should be a bytes-like object or ASCII string, not 'bool'

If you need it, I can push my current code to github.

objects.image is False... That means that field image is False on the object used into the report...
In fact into the demo template, we don't check if the image field is set before the call to b64decode... We should fix the template to avoid this kind of error.

tbaden

When I checked the object neither of the entries had images and only the last one failed. I'll check again.

tbaden · 2019-05-03T07:47:21Z

@lmignon @pedrobaeza
how should I handle this test?

    def test_py3o_report_availability(self):
        # This test could fails if libreoffice is not available on the server

locally it pass, because of libreoffice installation, but travis will fail.

tbaden · 2019-05-03T07:49:40Z

@lmignon maybe you can give me a hint. I got all tests on green now except for test_reports_merge_zip.
getting the error:
:1: in <Expression '__py3o_frame(b64decode(objects.image), 'png', width='2cm', height='2cm', origin_attrib={'{urn:oasis:names:tc:opendocument:xmlns:text:1.0}anchor-type': 'paragraph', '{urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0}width': '0.7902in', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}name': "py3o.image(b64decode(objects.image), 'png', width='2cm', height='2cm')", '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}style-name': 'fr1', '{urn:oasis:names:tc:opendocument:xmlns:drawing:1.0}z-index': '0'})'>
???
/usr/lib/python3.5/base64.py:81: in b64decode
s = _bytes_from_decode_data(s)
TypeError: argument should be a bytes-like object or ASCII string, not 'bool'
If you need it, I can push my current code to github.

objects.image is False... That means that field image is False on the object used into the report...
In fact into the demo template, we don't check if the image field is set before the call to b64decode... We should fix the template to avoid this kind of error.

seems like I dived to deep... found it and catching this issue in the context parser.

on local all tests are green

lmignon · 2019-05-03T07:52:12Z

@lmignon @pedrobaeza
how should I handle this test?
    def test_py3o_report_availability(self):
        # This test could fails if libreoffice is not available on the server
locally it pass, because of libreoffice installation, but travis will fail.

@tbaden add this commit by cherry-pick 😏 8d3b61a

lmignon · 2019-05-03T08:02:32Z

            report_xml._get_rendering_context(model_instance.ids, data)
        )
        context['objects'] = model_instance
+        # image false will crash base64 decoding


@tbaden The image field does not exist on all models. It is in the template that you must add an `if' instruction before using this field (it is a demo template)

how would this instruction look like in the odt template?
additional: wouldn't it be good to still check if image exists in objects and when false to set it to empty bytestring. otherwise you'll get an error if an user forgets this if instruction.

like this:

if ( hasattr(context['objects'], 'image') and not context['objects'].image ): context['objects'].image = b''

@tbaden A report can be defined for any model and the name of a field used to store an image is not always 'image'.
It's important to manage this case into the template to also avoid to display an empty square if the image is missing into the document.
You can use a control structure into the template to avoid to output an image if not set https://py3otemplate.readthedocs.io/en/latest/templating.html#use-control-structures

@lmignon done

@tbaden The demo template seems to no more work....

@lmignon the use of simplejson could fix this. what's your opinion on this?

like:

try: import simplejson as json except ImportError: import json

@tbaden Before introducing a new dependency I prefer to understand what's the root cause of the problem...

I'll reset my dev env and install it again. Maybe I messed it up somewhere for other developments.

I think we should try to stay with the standard python libraries. It doesn't seem normal to me that the result of serialization to json works with one library and not another when it shouldn't make any difference. I have the feeling that the problem encountered is elsewhere.

@lmignon I found the "issue". In v11 the portal User has no image, in v12 the portal user has an image. If you delete the image in v12 you get the exact same error:

File "/usr/lib/python3.5/base64.py", line 46, in _bytes_from_decode_data
"string, not %r" % s.class.name) from None
TypeError: argument should be a bytes-like object or ASCII string, not 'bool'

If I use my if structure template I get the same error:

E TypeError: b'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVQI12P4//8/AAX+Av7czFnnAAAAAElFTkSuQmCC' is not JSON serializable

So it's a general issue in v11 and v12. As you said, this should be caught in the odt template with an if structure. Maybe my if structure is still faulty. Could you please check my odt template

cataclysmic · 2020-01-25T14:37:07Z

What is the current situation with the backport? I'm using odoo 11 CE and would really like to try this module. I'd be willing to help. However, I'm a noob in odoo development.

github-actions · 2022-03-20T12:25:16Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

lmignon and others added 30 commits May 1, 2019 04:16

Move to report_py3o after import from HG

636ed6b

Add setup

6cd4f3c

[FIX] View inheritance may not use attribute 'string' as a selector.

30d4668

[IMP] New API + Short Hearder

1b93778

Remove unicode string

0621d19

[IMP] Add the possiblity to get the template from an absolute path on…

f96fb0b

… the server

[IMP] Allow user to use local fusion

ac7919a

Add a simple way to extend the parser context

b21000c

Remove ACL on removed model

1143c01

Improve filetype selection name

bad8827

Fix native flag

06ccc8c

fixed missing comma in model definition

5f50551

Add simple tests and fix call to fusion server

3c65764

Fix skip fusion on server when the fusion is local

77f0e8b

Improve tests

96a0099

Replace openerp element by odoo

c203cf4

Small usability improvements

576f8c8

Replace README.md by README.rst (not finished)

Take into accounts most remarks of @lasley

f0795db

Remove <data> in views Protect import of py3o libs Remove dep on base module Other small changes

Replace plain SQL by orm

c5c986d

rename module ir_report to ir_actions_report_xml

dbcfe38

Add more tests and fixes issues found by tests

9810b1f

[FIX] Check constrains only if report_type == 'py3o'

05ff3d5

report_py3o: full installation procedure in README

31b5bfb

Port report_py3o to Odoo v10

2cf13b7

Update version numbers

b565e5f

Rename __openerp__.py to __manifest__.py

PEP8 fix

80626fe

Update README

70974fa

FIX double dot in filename

97d0121

Add access to report_xml object in report

78a9578

FIX Adapt test suite to my recent commit to avoid double dot on filen…

d9fd643

…ame extension

lmignon and others added 7 commits May 1, 2019 04:16

[IMP] py3o_report: Allow to specify the lang when calling o_format_lang

39465d1

lang_code is already supported by o_format_date

[FIX] report_py3o: Access to ir.config_parameter with sudo

63b4f66

[FIX] report_py3o: respect _postprocess_report method signature

2a4a03c

Co-Authored-By: lmignon <laurent.mignon@acsone.eu>

[UPD] Update report_py3o.pot

e11a151

[UPD] Update report_py3o_fusion_server.pot

b9d08fa

Update translation files

1c6f705

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_py3o/

tbaden changed the title ~~[MIG][11.0] report_py3o backport of v12~~ [MIG][11.0][WIP] report_py3o backport of v12 May 1, 2019

tbaden mentioned this pull request May 1, 2019

[11.0][MIG] report_py3o (Work in Progress) #217

Closed

pedrobaeza added this to the 11.0 milestone May 1, 2019

lmignon requested changes May 3, 2019

View reviewed changes

tbaden commented May 3, 2019

View reviewed changes

lmignon requested changes May 3, 2019

View reviewed changes

tbaden changed the title ~~[MIG][11.0][WIP] report_py3o backport of v12~~ [MIG][11.0] report_py3o backport of v12 May 3, 2019

[MIG][11.0] report_py3o backport of v12

4bf56df

emagdalenaC2i mentioned this pull request Jun 1, 2019

Migration to version 11.0 #167

Closed

12 tasks

lmignon mentioned this pull request Jun 3, 2019

[MIG][11.0] report_py3o #292

Closed

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 20, 2022

github-actions Bot closed this Apr 24, 2022

Uh oh!

Conversation

tbaden commented May 1, 2019

Uh oh!

lmignon commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbaden commented May 2, 2019

Uh oh!

lmignon commented May 2, 2019

Uh oh!

tbaden commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oca-clabot commented May 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmignon commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbaden left a comment

Choose a reason for hiding this comment

Uh oh!

tbaden commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbaden commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmignon commented May 3, 2019

Uh oh!

lmignon May 3, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmignon May 3, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden May 3, 2019

Choose a reason for hiding this comment

Uh oh!

lmignon May 3, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmignon May 6, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmignon May 6, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden May 6, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cataclysmic commented Jan 25, 2020

Uh oh!

github-actions Bot commented Mar 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

lmignon commented May 2, 2019 •

edited

Loading

tbaden commented May 2, 2019 •

edited

Loading

lmignon commented May 3, 2019 •

edited

Loading

tbaden commented May 3, 2019 •

edited

Loading

tbaden commented May 3, 2019 •

edited

Loading

tbaden May 3, 2019 •

edited

Loading

tbaden May 3, 2019 •

edited

Loading

tbaden May 6, 2019 •

edited

Loading