Skip to content

[MIG][11.0] report_py3o - #292

Closed
vincent-hatakeyama wants to merge 98 commits into
OCA:11.0from
xcgd:11.0-mig-report_py3o
Closed

vincent-hatakeyama wants to merge 98 commits into
OCA:11.0from
xcgd:11.0-mig-report_py3o

Conversation

@vincent-hatakeyama

Copy link
Copy Markdown
Contributor

No description provided.

lmignon and others added 30 commits May 15, 2018 14:42
Replace README.md by README.rst (not finished)
Remove <data> in views
Protect import of py3o libs
Remove dep on base module
Other small changes
Rename __openerp__.py to __manifest__.py
tansadio and others added 23 commits July 2, 2018 16:50
To determine the method to use to render a recport according to its type, the generic method 'render' defined into ir.action.report check if a method name  is defined on the model. https://github.com/odoo/odoo/blob/12.0/odoo/addons/base/models/ir_actions_report.py#L734
Therefore, we must provide this method to be compliant with what's expected by Odoo.
This change will also allows the usage of py3o template with mail_template once odoo/odoo#30013 will be merged
This method was previously provided by Odoo and is used to merge all the reports generated if the generation is called for more than one record
…bility of py3o report

Before this change it was not possible to install modules declaring py3o report into a non native format without specifying a Fusion server once the module py3o_report_fusion_server was installed. With theses changes, we now take care of the availability of the libreoffice runtime to display/log a warning message when the report is in a non native runtime.
Was preventing attachments from getting saved.
@oca-clabot

Copy link
Copy Markdown

Hey @vincent-hatakeyama, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@lmignon

lmignon commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

@vincent-hatakeyama The migration is already done here #285 Can you take a look at this PR and review it to finalize it?

@lmignon lmignon closed this Jun 3, 2019
@vincent-hatakeyama

Copy link
Copy Markdown
Contributor Author

This migration is working, we have tested it. My company also created the module.

@lmignon

lmignon commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

@vincent-hatakeyama Which migration? Is it #285?

@vincent-hatakeyama

Copy link
Copy Markdown
Contributor Author

What we have tested is this PR.

@lmignon

lmignon commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Sorry but the PR #285 was there before this one and is working fine (except an issue to solve with the image tag). We only need some more reviews to merge-it. Can you test it so we can move forward and finalyse the migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.