Skip to content

[IMP] bi_sql_editor : conserve cron settings, when setting materialized view to draft ; Set correct default values for cron and enable it - #519

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
legalsylvain:12.0-IMP-bi_sql_editor-conserve-cron-values
Dec 16, 2021
Merged

OCA-git-bot merged 1 commit into
OCA:12.0from
legalsylvain:12.0-IMP-bi_sql_editor-conserve-cron-values

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor

Use case :

  • create materialized views, create models and configure the cron
  • reset to draft to change request. (adding / removing fields)
  • recreate models

-> the cron settings are lost and has to be set again.

With that patch :

  • cron are kept if materialized views are set to draft
  • default run values are now daily at midnight, beginning tomorrow (before was monthly with the datetime of the validation of the view that was making the cron to be refreshed immediately)
  • cron is now active by default. (and disabled when view is reset to draft)

CC @quentinDupont

apps/deck/#/board/144/card/1611

@etobella etobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@legalsylvain
legalsylvain force-pushed the 12.0-IMP-bi_sql_editor-conserve-cron-values branch from b019d10 to 1ee5238 Compare June 17, 2021 08:09
…ed view to draft ; Set correct default values for cron and enable it
@legalsylvain
legalsylvain force-pushed the 12.0-IMP-bi_sql_editor-conserve-cron-values branch from 1ee5238 to ab03f0e Compare June 17, 2021 08:11
@tfossoul

Copy link
Copy Markdown

@legalsylvain Hi, I would like to have this fix in v13. What is the right approach to do it ? Can I just cherry-pick your commit (+ fix eventual migration bug) into a new v13 branch and do a pull request ?

@legalsylvain

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@legalsylvain Hi, I would like to have this fix in v13. What is the right approach to do it ? Can I just cherry-pick your commit (+ fix eventual migration bug) into a new v13 branch and do a pull request ?

yes it should work.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

damn'it, not defined as maintainer of this module.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

now it is.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-519-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 984fe02 into OCA:12.0 Dec 16, 2021
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 5f022a5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants