Conversation
legalsylvain
left a comment
There was a problem hiding this comment.
Hi.
you could better cherry pick the commit of #519.
Not a big deal.
|
I tried. I got a huge amount of conflits.. And I prefer simply copy past by hand. |
fcf4a6b to
84adccd
Compare
| # Drop ORM | ||
| sql_view._drop_model_and_fields() | ||
|
|
||
| sql_view.write({"state": "draft", "has_group_changed": False}) |
There was a problem hiding this comment.
you should remove this line, because calling super do it.
see : https://github.com/OCA/reporting-engine/pull/519/files#diff-355785372a18bc17c4d5d51dcc29c551f88bdd3e13b7911276b07c1cec5792f8L289
…ed view to draft ; Set correct default values for cron and enable it
84adccd to
f9665d6
Compare
|
/ocabot merge patch |
|
Sorry @legalsylvain you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@legalsylvain I add you as mainteners. You should now be able to merge this pr... |
unfortunately not. I have to be declared maintainers of the target V13 module. That is quite a mess. We have to wait for a OCA/reporting-engine maintainers here. regards. |
796b27a to
9436286
Compare
9436286 to
27495cf
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
…ed view to draft ; Set correct default values for cron and enable it
Forward port from #519