[IMP][12.0] bi_sql_editor : use ace widget - #567
Merged
OCA-git-bot merged 1 commit intoDec 17, 2021
Merged
Conversation
Contributor
|
@legalsylvain done! |
houssine78
approved these changes
Dec 17, 2021
hparfr
approved these changes
Dec 17, 2021
Contributor
Author
|
thanks for your review ! |
florian-dacosta
approved these changes
Dec 17, 2021
rvalyi
approved these changes
Dec 17, 2021
Member
|
/ocabot merge minor |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at d77d99f. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
CC :
Note : unfortunately, In V12 (at least) it is not possible to use syntaxic color with something like
options="{'mode': 'sql'}"(unlike for xml, because ace javascript lib doesn't seems to be complete inwebmodule)