Skip to content

[MIG] Migrate report_xlsx to 16.0 - #654

Closed
adrienpeiffer wants to merge 68 commits into
OCA:16.0from
acsone:16.0-mig-report_xlsx-ape
Closed

adrienpeiffer wants to merge 68 commits into
OCA:16.0from
acsone:16.0-mig-report_xlsx-ape

Conversation

@adrienpeiffer

Copy link
Copy Markdown

No description provided.

Adrien Peiffer (ACSONE) and others added 30 commits October 4, 2022 09:51
…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method
* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format
* pass action to custom _downloadReportXLSX: Need action to get report data
* dict constructor to remove context lang
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 88.2% (15 of 17 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@adrienpeiffer

Copy link
Copy Markdown
Author

/ocabot migration

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @adrienpeiffer. Your command failed:

Invalid options for command migration: .

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@adrienpeiffer

Copy link
Copy Markdown
Author

/ocabot migration report_xlsx

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @adrienpeiffer you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@adrienpeiffer
adrienpeiffer marked this pull request as draft October 4, 2022 07:56
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration report_xlsx

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2022
16 tasks
@adrienpeiffer
adrienpeiffer force-pushed the 16.0-mig-report_xlsx-ape branch 2 times, most recently from 554106a to cc58150 Compare October 4, 2022 09:29
@adrienpeiffer
adrienpeiffer marked this pull request as ready for review October 4, 2022 09:30
Comment thread report_xlsx/controllers/main.py Outdated
@adrienpeiffer
adrienpeiffer force-pushed the 16.0-mig-report_xlsx-ape branch from 4cf8e60 to 083fc29 Compare October 7, 2022 14:57
@adrienpeiffer

Copy link
Copy Markdown
Author

Thanks @RodrigoBM

@RodrigoBM

Copy link
Copy Markdown
Contributor

@adrienpeiffer the branch now has conflicts, can you chek it

@JoanSForgeFlow JoanSForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Just needs a rebase and fix the conflict in requirements.txt

from odoo.tools import html_escape
from odoo.tools.safe_eval import safe_eval, time

from odoo.addons.web.controllers import report

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReportController should be imported like this

from odoo.addons.web.controllers.report import ReportController
class ReportController(ReportController):

because the controllers were reorganized

@maq-adhoc

Copy link
Copy Markdown

hi @adrienpeiffer . any news? if you don't have time, I can take it.

@pedrobaeza

Copy link
Copy Markdown
Member

Superseded by #690

@pedrobaeza pedrobaeza closed this Dec 4, 2022
@sbidoul
sbidoul deleted the 16.0-mig-report_xlsx-ape branch March 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.