Skip to content

12.0 mig auth oauth multi token - #106

Merged
OCA-git-bot merged 6 commits into
OCA:12.0from
fmdl:12.0-mig-auth_oauth_multi_token
Jul 2, 2019
Merged

12.0 mig auth oauth multi token#106
OCA-git-bot merged 6 commits into
OCA:12.0from
fmdl:12.0-mig-auth_oauth_multi_token

Conversation

@fmdl

@fmdl fmdl commented May 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Florent de Labarre and others added 5 commits May 31, 2019 15:09
@oca-clabot

oca-clabot commented May 31, 2019

Copy link
Copy Markdown

Hey @fmdl, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@fmdl fmdl mentioned this pull request May 31, 2019
Closed
@fmdl
fmdl force-pushed the 12.0-mig-auth_oauth_multi_token branch from b7b8f18 to 12cd54d Compare May 31, 2019 13:24
@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 2, 2019
Closed
19 tasks
tbaden
tbaden suggested changes Jun 2, 2019
View reviewed changes

@tbaden tbaden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review:
here some suggested changes

Comment thread auth_oauth_multi_token/README.rst
Comment thread auth_oauth_multi_token/__manifest__.py Outdated
Comment thread auth_oauth_multi_token/views/res_users.xml Outdated
Comment thread auth_oauth_multi_token/models/res_users.py Outdated
Comment thread auth_oauth_multi_token/models/res_users.py Outdated
Comment thread auth_oauth_multi_token/models/res_users.py Outdated
Comment thread auth_oauth_multi_token/tests/test_multi_token.py Outdated
Comment thread auth_oauth_multi_token/models/res_users.py
@fmdl
fmdl force-pushed the 12.0-mig-auth_oauth_multi_token branch 2 times, most recently from 9a56c94 to b9599d6 Compare June 3, 2019 20:53
@fmdl

fmdl commented Jun 22, 2019

Copy link
Copy Markdown
Contributor Author

@tbaden updated.

@fmdl

fmdl commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

cc @simahawk

simahawk
simahawk approved these changes Jun 26, 2019
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Comment thread auth_oauth_multi_token/views/auth_oauth_multi_token.xml Outdated
@fmdl
fmdl force-pushed the 12.0-mig-auth_oauth_multi_token branch from b9599d6 to f23eaee Compare July 1, 2019 18:51
@fmdl

fmdl commented Jul 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@pedrobaeza could you merge, thanks

@pedrobaeza

pedrobaeza commented Jul 2, 2019

Copy link
Copy Markdown
Member

/ocabot merge

@OCA-git-bot

OCA-git-bot commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-106-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit f23eaee into OCA:12.0 Jul 2, 2019
OCA-git-bot added a commit that referenced this pull request Jul 2, 2019
@OCA-git-bot
Merge PR #106 into 12.0
6daefd0 
Signed-off-by pedrobaeza
@OCA-git-bot

OCA-git-bot commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6daefd0. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@fmdl
fmdl deleted the 12.0-mig-auth_oauth_multi_token branch July 2, 2019 08:44
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#106 from OCA/12.0
12f8223 
Syncing from upstream OCA/server-auth (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes
+2 more reviewers
@tbaden tbaden tbaden requested changes
@sla-subteno-it sla-subteno-it sla-subteno-it approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@fmdl @oca-clabot @pedrobaeza @OCA-git-bot @simahawk @sla-subteno-it @tbaden @oca-travis