Skip to content

12.0 mig auth oauth multi token - #62

Closed
sla-subteno-it wants to merge 4 commits into
OCA:12.0from
subteno-it:12.0-mig-auth_oauth_multi_token
Closed

sla-subteno-it wants to merge 4 commits into
OCA:12.0from
subteno-it:12.0-mig-auth_oauth_multi_token

Conversation

@sla-subteno-it

Copy link
Copy Markdown

No description provided.

Florent de Labarre and others added 3 commits November 30, 2018 08:56
Allow multiple oauth login at the same time.
* cleanup, improve, docstrings
* add tests
@oca-clabot

Copy link
Copy Markdown

Hey @sla-subteno-it, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 30, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 30, 2018
19 tasks

@gurneyalex gurneyalex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, no test

'license': 'AGPL-3',
'author': 'Florent de Labarre, '
'Camptocamp, '
'Odoo Community Association (OCA)',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Odoo Community Association (OCA)',
'Odoo Community Association (OCA)'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comma is needed for proper dictionary format (it's outside the quote).

@pedrobaeza pedrobaeza Dec 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see now that they have added the new author after this...

But I don't consider this kind of migration should rise them to co-authors, so the solution is to remove that author.

@sla-subteno-it
sla-subteno-it force-pushed the 12.0-mig-auth_oauth_multi_token branch from aedb673 to 804b6c1 Compare December 18, 2018 22:27
@fmdl

fmdl commented May 31, 2019

Copy link
Copy Markdown
Contributor

move here #106

@emagdalenaC2i

Copy link
Copy Markdown

@fmdl and @sla-subteno-it should this PR be closed and superseed in #106 ?

@fmdl

fmdl commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

@emagdalenaC2i this PR doesn't work. Yes is superceded by #106

@emagdalenaC2i

Copy link
Copy Markdown

@fmdl So this PR should be closed

@pedrobaeza pedrobaeza closed this Jun 2, 2019
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants