[MIG] server_environment: Migration to 13.0 - #29
Merged
OCA-git-bot merged 43 commits intoOct 11, 2019
Merged
Conversation
(lp:c2c-addons/6.1 rev 11)
(lp:c2c-addons/6.1 rev 11.1.4)
(lp:c2c-addons/6.1 rev 28.1.1)
…t is the blessed target. (lp:c2c-addons/6.1 rev 40.2.1)
(lp:c2c-addons/6.1 rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target. (lp:c2c-addons/6.1 rev 116)
|
Hey @grindtildeath, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Tonow-c2c
approved these changes
Oct 9, 2019
| and init some properties | ||
|
|
||
| """ | ||
| ModelClass = super(ServerConfiguration, cls)._build_model(pool, cr) |
There was a problem hiding this comment.
Suggested change
| ModelClass = super(ServerConfiguration, cls)._build_model(pool, cr) | |
| ModelClass = super()._build_model(pool, cr) |
| def fields_view_get(self, view_id=None, view_type='form', toolbar=False, | ||
| submenu=False): | ||
| """Overwrite the default method to render the custom view.""" | ||
| res = super(ServerConfiguration, self).fields_view_get(view_id, |
There was a problem hiding this comment.
Suggested change
| res = super(ServerConfiguration, self).fields_view_get(view_id, | |
| res = super().fields_view_get(view_id, view_type, toolbar) |
gurneyalex
reviewed
Oct 10, 2019
grindtildeath
commented
Oct 10, 2019
grindtildeath
commented
Oct 10, 2019
gurneyalex
approved these changes
Oct 10, 2019
Member
|
@grindtildeath can you squash the fixup commits (including the old ones before your own from this migration)? |
This fixes OCA/server-tools#125 because in some Ubuntu systems lsb_release outputs to stderr as well as stdout. This message will be printed to console, not logged nor shown among server infomation. That way the message is lost and only pollutes unit tests output.
* [IMP] load server environment options from odoo rcfile This allows delivering the code with default configuration options for all environments in the server_environment_file module, but letting the administrator override some configuration entries in the regular odoo configuration file. * server_environment_file: update README
To trigger rebuild following change in setup.py
Add SERVER_ENV_CONFIG_SECRET alongside SERVER_ENV_CONFIG Allows to isolate the secrets in your deployment Improve documentation regarding variables Add a server environment mixin To automatically convert fields into fields reading values from the environment. Until now, every module reimplements the same computed field. Read default values from database when no config is provided Automatically add <field_name>_env_default for every field transformed to a "computed from env" field, so a default value can be set. It will be used when the configuration is not set in a configuration file (when the key is absent, not empty). Allow to edit default values for env-computed fields When they don't have any key in the environment configuration files. In the UI, when a field is set in a configuration file, the field is readonly, if not the field is editable. Which means you can selectively choose which fields depend on the environment and which can use a "default" value stored in database. Fix a few small issues in mixin Use a dictionary to configure the fields Add global section Disable prefetch on env-computed fields As in the inverse field that write the value into the <field>_env_default we have to browse the record, the prefetch has the effect of calling compute on the env-computed field which resets the value to it's previous state before we have the occasion to store it. Use global section name as first part of the section Allow to edit all fields on creation Make server_environment_files optional Allow integration with keychain By adding options to change the compute and inverse methods for default fields Update documentation of server_environment, bump Add SERVER_ENV_CONFIG_SECRET alongside SERVER_ENV_CONFIG Allows to isolate the secrets in your deployment Reinforce server_environment base tests Add tests for the server env mixin Infer configparser getter from field type Fixes for review feedbacks Add tests and support of _inherits Use SavepointCase instead of TransactionCase It means less records to create for each test Fix iteration on records
… users New security group restricting access to server config Admin is part of the group by default
grindtildeath
force-pushed
the
13.0-mig-server_environment
branch
from
October 11, 2019 07:33
dbbc7c1 to
bb73c66
Compare
Contributor
Author
|
@gurneyalex Done ;) |
Member
|
/ocabot merge |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 11, 2019
Contributor
|
Congratulations, your PR was merged at 75b3811. Thanks a lot for contributing to OCA. ❤️ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.