[MIG] server_environment_ir_config_parameter: Migration to 13.0 - #30
OCA-git-bot merged 24 commits into
Conversation
[11.0] keychain: improve ACL and allow storing ssh keys as password OCA#30
Tonow-c2c
left a comment
There was a problem hiding this comment.
@grindtildeath You have dependence error in travis
but code LGTM
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
|
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-30-by-yvaucher-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-30-by-yvaucher-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@grindtildeath can you rebase? |
… values This is much more robust that raising an error, and let modules load ir.config_parameter from xml data files, while still enforcing values from the config files.
Odoo loads modules that contain static directory, so it wanted to load server_environment_files but it does not exist
Without this sudo get_param would fail when the first user reading a parameter that has changed in the configuration file does not have write access to system parameters.
Manual forward port of 11.0 migration commit by Thierry Ducrest.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-env-12.0/server-env-12.0-server_environment_ir_config_parameter Translate-URL: https://translation.odoo-community.org/projects/server-env-12-0/server-env-12-0-server_environment_ir_config_parameter/
6de2a41 to
0246d9f
Compare
|
@grindtildeath seems that you also need to re-run the pre-commit hook. |
|
@yvaucher Should be better now :) |
|
@grindtildeath good one step further lint passes now. But pytest fails on some tests of this module. |
…v_config application
Before, the values used in the tests were coming from server_environment_files_sample that were made available using a symbolic link in .travis.yml. Now, it's loaded dynamically at test execution.
53deee8 to
3fb6489
Compare
yvaucher
left a comment
There was a problem hiding this comment.
🎉 thanks for the fix in the tests
Good to be merged.
|
/ocabot merge |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at bc7ea2e. Thanks a lot for contributing to OCA. ❤️ |
depends on: