Skip to content

[IMP] override dbfilter instead of superposing it - #1918

Closed
kh-badep wants to merge 1 commit into
OCA:12.0from
BADEP:patch-1
Closed

kh-badep wants to merge 1 commit into
OCA:12.0from
BADEP:patch-1

Conversation

@kh-badep

Copy link
Copy Markdown

The current behavior does not correspond to the description of the module: If there is already a dbfilter defined in the config file or as a parameter, this module will add the new dbfilter to the old one hence further filtering out the databases.

This proposed changes will instead completely override the old dbfilter with the new one, giving more flexibility to its use.

The current behavior does not correspond to the description of the module: If there is already a dbfilter defined in the config file or as a parameter, this module will add the new dbfilter to the old one hence further filtering out the databases.

This proposed changes will instead completely override the old dbfilter with the new one, giving more flexibility to its use.

@PieterPaulussen PieterPaulussen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically, this looks exactly the same.

@kh-badep

Copy link
Copy Markdown
Author

There's a difference:

  • If no dbfilter is defined in the config file, then the behavior will be the same
  • If there is a dbfilter in the config AND a dbfilter in the header then this new change will disregard the original dbfilter and replace it with the dbfilter from header, which I suppose is the intended purpose.

@cvinh

cvinh commented Aug 1, 2022

Copy link
Copy Markdown

@kh-badep I did not see your PR before
I did another PR that fixes the issue here #2353

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants