[14.0][FIX] dbs value has to be kept in case of special dbfilter config - #2353
Conversation
94240a1 to
526b337
Compare
| if db_filter_hdr: | ||
| dbs = [db for db in dbs if re.match(db_filter_hdr, db)] | ||
| else: | ||
| dbs = dbs_orig |
There was a problem hiding this comment.
Could you explain what this actually changes, because I don't see it.
dbs = something
if condition:
dbs = something_other
return dbs
Should be functionally equivalent to:
dbs_orig = something
if condition:
dbs = something_other
else:
dbs = dbs_orig
return dbs
There was a problem hiding this comment.
thanks for reviewing
In the previous code, as dbs was already in the arguments, it was overwritten by
dbs = db_filter_org(dbs, httprequest)
|
ping @kh-badep |
|
@hbrunn Could you perhaps glance over quickly and approve also? It's a good fix IMO |
hbrunn
left a comment
There was a problem hiding this comment.
if using the default filter mechanism, why have this module installed in the first place? But I also don't see how this hurts
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5537b42. Thanks a lot for contributing to OCA. ❤️ |
I had to commit this fix to make it work on our architecture
Our dbfilter is
dbfilter = %d$Our proxy is Apache 2.4.6