[13.0][FIX]database_cleanup: Don't purge by default - #2773
thomaspaulb wants to merge 2 commits into
Conversation
Modules should not be purged when completing scan without explicit user consent. Instead select modules to purge from results.
b6671c6 to
703e576
Compare
|
@hbrunn Gosh, tour tests are failing on a line in |
|
not encountered before. Code having to detect if it's running in tests very often is a problem with the tests or with the code anyways. One of them should be rewritten, or if that's not feasible/possible, the module isolated into a rebel group |
|
Trying a merge |
|
What a great day to merge this nice PR. Let's do it! |
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-2773-by-dreispt-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@OCA/community-maintainers Not sure whether this is the right OCA team. Unfortunately there is no real documentation of what OCA user to call for a certain repo here: https://oca.github.io/repo-maintainer-conf/maintainer.html Anyway this is one of 10 PR's in this repo that are Ready to Merge. Would be nice if all Ready to Merge PR's where indeed merged. |
|
@NL66278 |
|
@dreispt I far as I can see the dependency is no longer there after further changes, but is difficult to know as for some reason tests did mot run, only 2 checks done. @thomaspaulb You are the author of this PR, is the dependency still needed. Anyway my remark was also about all the other Ready for merge, but not merged PR's, some ready for a long time. As the server-tools is a quite important repository, that worries me. |
Forward port of #1978