Skip to content

[13.0][FIX]database_cleanup: Don't purge by default - #2773

Open
thomaspaulb wants to merge 2 commits into
OCA:13.0from
sunflowerit:13.0-database_cleanup-dont_auto_purge
Open

thomaspaulb wants to merge 2 commits into
OCA:13.0from
sunflowerit:13.0-database_cleanup-dont_auto_purge

Conversation

@thomaspaulb

@thomaspaulb thomaspaulb commented Dec 3, 2023

Copy link
Copy Markdown
Contributor

Forward port of #1978

@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 24, 2023
diggy128 and others added 2 commits February 23, 2024 17:42
Modules should not be purged when completing scan without
explicit user consent. Instead select modules to purge from results.
@thomaspaulb
thomaspaulb force-pushed the 13.0-database_cleanup-dont_auto_purge branch from b6671c6 to 703e576 Compare February 23, 2024 16:45
@thomaspaulb

Copy link
Copy Markdown
Contributor Author

@hbrunn Gosh, tour tests are failing on a line in base_remote, which asserts something unless test_enable = True; but when the tour calls the backend, test_enable apparently is False. Have you encountered this before, and/or have an idea how to fix?

@hbrunn

hbrunn commented Feb 26, 2024

Copy link
Copy Markdown
Member

not encountered before. Code having to detect if it's running in tests very often is a problem with the tests or with the code anyways. One of them should be rewritten, or if that's not feasible/possible, the module isolated into a rebel group

@dreispt

dreispt commented Apr 23, 2024

Copy link
Copy Markdown
Member

Trying a merge
/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-2773-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 23, 2024
Signed-off-by dreispt
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-2773-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 26, 2026
@NL66278

NL66278 commented May 18, 2026

Copy link
Copy Markdown
Contributor

@OCA/community-maintainers Not sure whether this is the right OCA team. Unfortunately there is no real documentation of what OCA user to call for a certain repo here: https://oca.github.io/repo-maintainer-conf/maintainer.html Anyway this is one of 10 PR's in this repo that are Ready to Merge. Would be nice if all Ready to Merge PR's where indeed merged.

@dreispt

dreispt commented May 18, 2026

Copy link
Copy Markdown
Member

@NL66278
This PR failed the merge and probably needs fixing (or is it a CI issue?)
Also, it lists a dependency that is waiting to be merged, so that should be blocking.

@NL66278

NL66278 commented May 18, 2026

Copy link
Copy Markdown
Contributor

@dreispt I far as I can see the dependency is no longer there after further changes, but is difficult to know as for some reason tests did mot run, only 2 checks done. @thomaspaulb You are the author of this PR, is the dependency still needed. Anyway my remark was also about all the other Ready for merge, but not merged PR's, some ready for a long time. As the server-tools is a quite important repository, that worries me.

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants