Skip to content

[13.0][FIX]database_cleanup: Don't purge by default #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomaspaulb wants to merge 2 commits into
base: 13.0
Choose a base branch
from
Open

[13.0][FIX]database_cleanup: Don't purge by default #2773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8628d1
[12.0][FIX]database_cleanup: Don't purge by default
diggy128 Jan 3, 2021
703e576
fixup! [12.0][FIX]database_cleanup: Don't purge by default
Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions database_cleanup/models/purge_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ def find(self):
continue
res.append((0, 0, {"name": module.name}))

purge_lines.purge()

if not res:
raise UserError(_("No modules found to purge"))
return res
Expand Down
12 changes: 9 additions & 3 deletions database_cleanup/tests/test_database_cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,21 +141,27 @@ def keep_registry():

with keep_registry(), mute_logger("odoo.modules.graph", "odoo.modules.loading"):
purge_modules = self.env["cleanup.purge.wizard.module"].create({})
# this module should be purged already during default_get
self.assertFalse(
# no modules are purged during default_get
self.assertTrue(
self.env["ir.module.module"].search(
[("name", "=", "database_cleanup_test_uninstalled")]
)
)

with keep_registry(), mute_logger("odoo.modules.graph", "odoo.modules.loading"):
purge_modules.purge_all()
# must be removed by the wizard
# installed modules must be removed by the wizard
self.assertFalse(
self.env["ir.module.module"].search(
[("name", "=", "database_cleanup_test")]
)
)
# uninstalled modules must be removed by the wizard
self.assertFalse(
self.env["ir.module.module"].search(
[("name", "=", "database_cleanup_test_uninstalled")]
)
)

def tearDown(self):
with self.registry.cursor() as cr2:
Expand Down