[MIG][17.0] base_name_search_improved - #2833
Closed
PieterJanCassiman wants to merge 6 commits into
Closed
PieterJanCassiman wants to merge 6 commits into
PieterJanCassiman wants to merge 6 commits into
Conversation
…le of calling super
PieterJanCassiman
force-pushed
the
17.0-mig
branch
from
February 8, 2024 08:21
1dab492 to
6bde685
Compare
PieterJanCassiman
force-pushed
the
17.0-mig
branch
from
February 8, 2024 08:23
6bde685 to
0faae92
Compare
thomaspaulb
reviewed
Feb 12, 2024
| self.smart_search = False | ||
|
|
||
| @api.model | ||
| def _search_smart_search(self, operator, value): |
Contributor
There was a problem hiding this comment.
While it looks like smart search is included in tests, this function does not seem to receive test coverage. Any idea why?
Member
|
Please apply the technical method described in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to to preserve the full commit history. |
|
Hi! I was wondering - is there still ongoing work on this? Does it work functionally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.