Skip to content

[12.0][FIX]database_cleanup: Don't purge by default - #2857

Closed
thomaspaulb wants to merge 1 commit into
OCA:12.0from
sunflowerit:12.0_database_cleanup
Closed

[12.0][FIX]database_cleanup: Don't purge by default#2857
thomaspaulb wants to merge 1 commit into
OCA:12.0from
sunflowerit:12.0_database_cleanup

Conversation

@thomaspaulb

@thomaspaulb thomaspaulb commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replaces #1978

(PR is the same, just tests are modified as per the discussion that followed)

This was referenced Feb 23, 2024
Merged
Closed
@thomaspaulb
thomaspaulb force-pushed the 12.0_database_cleanup branch 2 times, most recently from 7eef456 to 9b5d77d Compare February 24, 2024 09:18
@thomaspaulb

thomaspaulb commented Feb 24, 2024

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2857-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 24, 2024
@OCA-git-bot
Merge PR #2857 into 12.0
4911e7a 
Signed-off-by thomaspaulb
@OCA-git-bot

OCA-git-bot commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-2857-by-thomaspaulb-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@diggy128 Tom Blauwendraat
[12.0][FIX]database_cleanup: Don't purge by default
4a75ac5 
Modules should not be purged when completing scan without
explicit user consent. Instead select modules to purge from results.
@thomaspaulb
thomaspaulb force-pushed the 12.0_database_cleanup branch from 9b5d77d to 4a75ac5 Compare February 24, 2024 09:37
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 7, 2026
@github-actions github-actions Bot closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomaspaulb @OCA-git-bot @diggy128