[12.0][DEL] profiler: tour test - #2859
Merged
OCA-git-bot merged 2 commits intoFeb 23, 2024
Merged
Conversation
thomaspaulb
force-pushed
the
12.0-profiler-remove-tour-test
branch
from
February 23, 2024 21:09
4696635 to
06187b0
Compare
Merged
Contributor
Author
|
Merging, since I'm maintainer and this failed test was blocking #2857 /ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at d66f2c3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I once thought tours were a cool way of testing modules, but I've run into more problems then it has given merit, and also, there's another regular test which covers the use case of the module - coverage won't go down.
Removing the tour test, so I don't have to spend time maintaining it and fixing pipelines.