[18.0][MIG] base_view_inheritance_extension by fredericgrall · Pull Request #3100 · OCA/server-tools

fredericgrall · 2024-10-29T18:36:02Z

No description provided.

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

expression not match the node any more. Fixes OCA#885

* warning about dynamic context * import for safe_eval

Use https in URL to licence

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_view_inheritance_extension/

…d list_remove

* Removed `list_add` and `list_remove`, they've been deprecated and implemented in Odoo core since several versions ago. * Removed `move`, as it has also already been implemented in core several versions ago. * Replaced `python_dict` by `update`, that performs an operation similar to :meth:`dict.update`, but on the ast.Dict.

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/es_AR/

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/es/

… text_add

…out previous domain defined

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_view_inheritance_extension/

gdgellatly · 2024-10-29T20:10:54Z

        self.assertEqual(
            res.xpath('//field[@name="invoice_line_ids"]')[0].attrib["context"],
-            "{%s}" % ", ".join(expected_items),
+            "{%s}" % ", ".join(expected_items),  # noqa: UP031


This is easy enough to avoid needing and we should try as hard as possible to only have absolutely necessary linting exceptions IMO. Odoo's own CI now fails if a linting exception is used after some high profile security issues introduced. That said I am not sure the current state of f-string vs format vs printf discussions in OCA. Last I knew it was f-string bad, printf bad, use format. Maybe someone who knows better can help here as a few f-string conversions up higher.

Anyway it won't stop me installing and testing so will give it a go now.

gdgellatly

Tested context update using https://github.com/odoonz/odoonz-addons/tree/18.0/stock_prodlot_qty - which has multiple upstream views with context - works as expected

gdgellatly

Make secure, also concerns around tests and applicability IRT attrs, which may explain lack of test coverage of all the main methods in module.

gdgellatly · 2024-10-29T22:20:32Z

+    @api.model
+    def _get_inheritance_handler_attributes(self, node):
+        handler = super().apply_inheritance_specs
+        if hasattr(self, f"inheritance_handler_attributes_{node.get('operation')}"):


should check/call a private method

gdgellatly · 2024-10-29T22:20:45Z

+        return handler
+
+    @api.model
+    def inheritance_handler_attributes_update(self, source, specs):


should be private

gdgellatly · 2024-10-29T22:21:11Z

+    @api.model
+    def _get_inheritance_handler_attributes(self, node):
+        handler = super().apply_inheritance_specs
+        if hasattr(self, f"inheritance_handler_attributes_{node.get('operation')}"):


Suggested change

if hasattr(self, f"inheritance_handler_attributes_{node.get('operation')}"):

if hasattr(self, f"_inheritance_handler_attributes_{node.get('operation')}"):

gdgellatly · 2024-10-29T22:21:26Z

+        handler = super().apply_inheritance_specs
+        if hasattr(self, f"inheritance_handler_attributes_{node.get('operation')}"):
+            handler = getattr(
+                self, f"inheritance_handler_attributes_{node.get('operation')}"


Suggested change

self, f"inheritance_handler_attributes_{node.get('operation')}"

self, f"_inheritance_handler_attributes_{node.get('operation')}"

gdgellatly · 2024-10-29T22:21:42Z

+        return handler
+
+    @api.model
+    def inheritance_handler_attributes_update(self, source, specs):


Suggested change

def inheritance_handler_attributes_update(self, source, specs):

def _inheritance_handler_attributes_update(self, source, specs):

gdgellatly · 2024-10-29T22:23:00Z

+                    self.var2str_domain_text(old_value.strip())
+                )
+                new_domain = ast.literal_eval(
+                    self.var2str_domain_text(attribute_node.text.strip())


Suggested change

self.var2str_domain_text(attribute_node.text.strip())

self._var2str_domain_text(attribute_node.text.strip())

gdgellatly · 2024-10-29T22:23:36Z

+        return re.sub(regex, r"'\1_is_a_var_to_replace'", domain_str)
+
+    @api.model
+    def str2var_domain_text(self, domain_str):


Suggested change

def str2var_domain_text(self, domain_str):

def _str2var_domain_text(self, domain_str):

gdgellatly · 2024-10-29T22:23:43Z

+        return source
+
+    @api.model
+    def var2str_domain_text(self, domain_str):


Suggested change

def var2str_domain_text(self, domain_str):

def _var2str_domain_text(self, domain_str):

gdgellatly · 2024-10-29T22:24:07Z

+                    new_value = str(expression.OR([old_domain, new_domain]))
+                else:
+                    new_value = str(expression.AND([old_domain, new_domain]))
+                new_value = self.str2var_domain_text(new_value)


Suggested change

new_value = self.str2var_domain_text(new_value)

new_value = self._str2var_domain_text(new_value)

gdgellatly · 2024-10-29T22:25:53Z

+            <form>
+                <field
+                    name="ref"
+                    attrs="{'invisible': [('state', '=', 'draft')]}"


This test makes no sense? - attrs is gone in v18. Hmm, this might have big consequences for module - all these tests containing attrs I think will need changing.

xaviedoanhduy

For being easily searchable and avoiding to duplicate efforts, please name the pull request following this pattern: [18.0][MIG] : Migration to 18.0.

and please check the CI

youring · 2024-10-30T07:42:05Z

Would you please consider pick these two commits for v16.0 if approprate? Thanks.
de26c37
d7484f4

gdgellatly · 2024-10-30T09:12:49Z

For being easily searchable and avoiding to duplicate efforts, please name the pull request following this pattern: [18.0][MIG] : Migration to 18.0.

and please check the CI

@xaviedoanhduy Maybe you could help him? I mean I've done this a long time, and I have no idea why a set of unrelated modules caused errors like that or what I would need to do to fix

fredericgrall · 2024-10-30T11:08:15Z

@gdgellatly,I'm going to modify to use a private method, thank you for your comments and I'm a little confused about the modifications needed for the CI.

pedrobaeza · 2024-11-14T07:13:33Z

Yes.

hbrunn and others added 30 commits October 29, 2024 17:11

[ADD] base_view_inheritance_extension

710a05b

[base_view_inheritance_extension] Relicense to LGPL. (OCA#4)

a05d4e3

[MIG] base_view_inheritance_extension: Migration to 9.0

205f05a

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[8.0][ADD] Add list manipulation operations to base_view_inheritance_…

43938f8

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

[MIG] base_view_inheritance_extension to 10.0

2d68d49

[FIX] don't break when an attribute node in an xpath makes the

7762e93

expression not match the node any more. Fixes OCA#885

[FIX] base_view_inheritance_extension: 2 things:

bc17bef

* warning about dynamic context * import for safe_eval

[UPD] Update base_view_inheritance_extension.pot

e767c95

[MIG] base_view_inheritance_extension: Migration to 11.0

733439e

[UPD] Update base_view_inheritance_extension.pot

51af698

[MIG] base_view_inheritance_extension: Migration to 12.0

54a0d60

Remove the "move" feature which is now native

ee5438b

Use https in URL to licence

[UPD] Update base_view_inheritance_extension.pot

86058a1

[UPD] README.rst

2dacde3

[IMP] base_view_inheritance_extension: black, isort

e6943e3

[MIG] base_view_inheritance_extension: Migration to v13.0

7db4277

[UPD] Update base_view_inheritance_extension.pot

094ef61

FIX: add missing params on function apply_inheritance_specs

86ea351

base_view_inheritance_extension 13.0.1.0.1

a4c7523

[MIG] base_view_inheritance_extension to v14

3d7ccda

Fix apply inheritance specs on views (pre_locate)

341f7ea

[UPD] Update base_view_inheritance_extension.pot

bb614df

[UPD] README.rst

e2a2254

base_view_inheritance_extension 14.0.1.0.1

cb45240

[IMP] base_view_inheritance_extension: real python_dict

0f32d99

[UPD] base_view_inheritance_extension: readme - deprecate list_add an…

636e64d

…d list_remove

[UPD] README.rst

22edd52

base_view_inheritance_extension 14.0.1.1.0

d5257ce

ibuioli and others added 15 commits October 29, 2024 17:11

[UPD] README.rst

d67f7b8

[IMP] base_view_inheritance_extension: Add new options domain_add and…

3b3729e

… text_add

[FIX] base_view_inheritance_extension: Crash domain for elements with…

ba71045

…out previous domain defined

[BOT] post-merge updates

776d7c6

[IMP] base_view_inheritance_extension: pre-commit auto fixes

ef402c0

[MIG] base_view_inheritance_extension to v17

38e901e

[UPD] Update base_view_inheritance_extension.pot

52f0ecd

[BOT] post-merge updates

6951d6f

[FIX] *: Pre-commit fixes

6c11813

[BOT] post-merge updates

fc9b351

[IMP] base_view_inheritance_extension: pre-commit auto fixes

a43f0b9

fredericgrall mentioned this pull request Oct 29, 2024

Migration to version 18.0 #3047

Open

42 tasks

fredericgrall force-pushed the 18.0-mig-base_view_inheritance_extension branch from c57e742 to c666397 Compare October 29, 2024 19:01

[MIG] base_view_inheritance_extension: Migration to 18.0

3251ed6

fredericgrall force-pushed the 18.0-mig-base_view_inheritance_extension branch from c666397 to 3251ed6 Compare October 29, 2024 19:02

gdgellatly reviewed Oct 29, 2024

View reviewed changes

gdgellatly suggested changes Oct 29, 2024

View reviewed changes

xaviedoanhduy suggested changes Oct 30, 2024

View reviewed changes

sebalix changed the title ~~18.0 mig base view inheritance extension~~ [18.0][MIG] base_view_inheritance_extension Nov 6, 2024

pedrobaeza closed this Nov 14, 2024

LucasTran380381 mentioned this pull request Nov 25, 2024

[18.0][MIG] base_view_inheritance_extension: Migration to 18.0 #3120

Merged

	if hasattr(self, f"inheritance_handler_attributes_{node.get('operation')}"):
	if hasattr(self, f"_inheritance_handler_attributes_{node.get('operation')}"):

	self, f"inheritance_handler_attributes_{node.get('operation')}"
	self, f"_inheritance_handler_attributes_{node.get('operation')}"

	def inheritance_handler_attributes_update(self, source, specs):
	def _inheritance_handler_attributes_update(self, source, specs):

	self.var2str_domain_text(attribute_node.text.strip())
	self._var2str_domain_text(attribute_node.text.strip())

	def str2var_domain_text(self, domain_str):
	def _str2var_domain_text(self, domain_str):

	def var2str_domain_text(self, domain_str):
	def _var2str_domain_text(self, domain_str):

	new_value = self.str2var_domain_text(new_value)
	new_value = self._str2var_domain_text(new_value)

Uh oh!

Uh oh!

Conversation

fredericgrall commented Oct 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy left a comment

Choose a reason for hiding this comment

Uh oh!

youring commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gdgellatly commented Oct 30, 2024

Uh oh!

fredericgrall commented Oct 30, 2024

Uh oh!

pedrobaeza commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

youring commented Oct 30, 2024 •

edited

Loading