[18.0][MIG] base_view_inheritance_extension: Migration to 18.0 by LucasTran380381 · Pull Request #3120 · OCA/server-tools

LucasTran380381 · 2024-11-14T05:20:44Z

Supersedes #3100

Due to attrs attribute is not use anymore in odoo v17 and later. => change to use context to make test-case suitable
Add test-case for operation="text_add" and operation="domain_add"

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

expression not match the node any more. Fixes OCA#885

* warning about dynamic context * import for safe_eval

Use https in URL to licence

…d list_remove

* Removed `list_add` and `list_remove`, they've been deprecated and implemented in Odoo core since several versions ago. * Removed `move`, as it has also already been implemented in core several versions ago. * Replaced `python_dict` by `update`, that performs an operation similar to :meth:`dict.update`, but on the ast.Dict.

Currently translated at 100.0% (3 of 3 strings) Translation: server-tools-15.0/server-tools-15.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_view_inheritance_extension/es_AR/

This fixes an error we could get if the attribute of the inherited tag has some extra carriage returns. Exception raised: SyntaxError: unexpected EOF while parsing

Currently translated at 100.0% (3 of 3 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/it/

Currently translated at 100.0% (3 of 3 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/hr/

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/es_AR/

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-16.0/server-tools-16.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_view_inheritance_extension/es/

… text_add

…out previous domain defined

remove loggin

…extension

hbrunn

migration itself is fine, but the test code you removed tests the valuable case where the dictionary doesn't exist in the base view.

And given there was barely anything to do for this migration, I think it's fair to ask for test cases for operation="text_add" and/or operation="domain_add"

hbrunn · 2024-11-21T13:40:30Z

/ocabot migration base_view_inheritance_extension

LucasTran380381 · 2024-11-22T03:06:11Z

migration itself is fine, but the test code you removed tests the valuable case where the dictionary doesn't exist in the base view.

And given there was barely anything to do for this migration, I think it's fair to ask for test cases for operation="text_add" and/or operation="domain_add"

Thanks for review. I have add test-case for 2 operation

[MIG] base_view_inheritance_extension: Migration to 18.0 Co-authored-by: Lukas Tran <nhant@trobz.com>

OCA-git-bot · 2024-11-25T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hbrunn · 2024-11-25T10:49:51Z

/ocabot merge nobump

OCA-git-bot · 2024-11-25T10:49:58Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3120-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-25T10:53:46Z

Congratulations, your PR was merged at f2b20d9. Thanks a lot for contributing to OCA. ❤️

hbrunn and others added 30 commits November 14, 2024 10:16

[ADD] base_view_inheritance_extension

6708be4

[base_view_inheritance_extension] Relicense to LGPL. (OCA#4)

05045ef

[MIG] base_view_inheritance_extension: Migration to 9.0

e3fc18e

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[8.0][ADD] Add list manipulation operations to base_view_inheritance_…

98f1b35

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

[MIG] base_view_inheritance_extension to 10.0

f90c4c2

[FIX] don't break when an attribute node in an xpath makes the

8006414

expression not match the node any more. Fixes OCA#885

[FIX] base_view_inheritance_extension: 2 things:

130ed4a

* warning about dynamic context * import for safe_eval

[MIG] base_view_inheritance_extension: Migration to 11.0

240c2ce

[MIG] base_view_inheritance_extension: Migration to 12.0

dc84d2e

Remove the "move" feature which is now native

173a02d

Use https in URL to licence

[IMP] base_view_inheritance_extension: black, isort

be144ac

[MIG] base_view_inheritance_extension: Migration to v13.0

e7d99ec

FIX: add missing params on function apply_inheritance_specs

ffba189

[MIG] base_view_inheritance_extension to v14

64996ba

Fix apply inheritance specs on views (pre_locate)

a62603a

[IMP] base_view_inheritance_extension: real python_dict

3606ea2

[UPD] base_view_inheritance_extension: readme - deprecate list_add an…

8b3791c

…d list_remove

[IMP] Update development_status Mature

f6e739e

Added translation using Weblate (Spanish (Argentina))

71289af

[FIX] b_v_inheritance_extension: fix parsing of 'update' operation

30c6a22

This fixes an error we could get if the attribute of the inherited tag has some extra carriage returns. Exception raised: SyntaxError: unexpected EOF while parsing

[MIG] base_view_inheritance_extension: Migration to 16.0

f0bcab6

[MIG] base_view_inheritance_extension: Fix demo view

f49c29b

[IMP] base_view_inheritance_extension: Add new options domain_add and…

e2d51aa

… text_add

[FIX] base_view_inheritance_extension: Crash domain for elements with…

f688954

…out previous domain defined

LucasTran380381 force-pushed the 18.0-mig-base_view_inheritance_extension branch 2 times, most recently from 8be1ae8 to 993b8ab Compare November 19, 2024 04:36

LucasTran380381 marked this pull request as ready for review November 20, 2024 03:33

LucasTran380381 mentioned this pull request Nov 20, 2024

Migration to version 18.0 #3047

Open

42 tasks

pedrobaeza and others added 5 commits November 20, 2024 15:56

[FIX] *: Pre-commit fixes

ca43420

base_view_inheritance_extension: wrap import

feb668e

remove loggin

[FIX] base_view_inheritance_extension: parse old value

baf7042

oca-port: blacklist PR(s) 1937, 2216, 2457 for base_view_inheritance_…

c5a8825

…extension

[IMP] base_view_inheritance_extension: pre-commit auto fixes

1e869fc

LucasTran380381 force-pushed the 18.0-mig-base_view_inheritance_extension branch from 993b8ab to 0d7706f Compare November 20, 2024 09:01

LucasTran380381 changed the title ~~[MIG] base_view_inheritance_extension: Migration to 18.0~~ [18.0][MIG] base_view_inheritance_extension: Migration to 18.0 Nov 20, 2024

hbrunn requested changes Nov 21, 2024

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Nov 21, 2024

LucasTran380381 force-pushed the 18.0-mig-base_view_inheritance_extension branch from 0d7706f to da18c96 Compare November 22, 2024 03:05

[MIG] base_view_inheritance_extension: Migration to 18.0

c9e0dec

[MIG] base_view_inheritance_extension: Migration to 18.0 Co-authored-by: Lukas Tran <nhant@trobz.com>

LucasTran380381 force-pushed the 18.0-mig-base_view_inheritance_extension branch from da18c96 to c9e0dec Compare November 22, 2024 03:11

hbrunn approved these changes Nov 22, 2024

View reviewed changes

sebalix approved these changes Nov 25, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 25, 2024

OCA-git-bot added the bot is merging ⏳ label Nov 25, 2024

OCA-git-bot merged commit 75a2dc6 into OCA:18.0 Nov 25, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 25, 2024

Navigation Menu

Uh oh!

Uh oh!

[18.0][MIG] base_view_inheritance_extension: Migration to 18.0 - #3120

[18.0][MIG] base_view_inheritance_extension: Migration to 18.0#3120
OCA-git-bot merged 39 commits into
OCA:18.0from
LucasTran380381:18.0-mig-base_view_inheritance_extension

LucasTran380381 commented Nov 14, 2024 •

edited

Loading

Uh oh!

hbrunn left a comment

Uh oh!

hbrunn commented Nov 21, 2024

Uh oh!

LucasTran380381 commented Nov 22, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

hbrunn commented Nov 25, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

LucasTran380381 commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

hbrunn commented Nov 21, 2024

Uh oh!

LucasTran380381 commented Nov 22, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

hbrunn commented Nov 25, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

OCA-git-bot commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

LucasTran380381 commented Nov 14, 2024 •

edited

Loading