[18.0][MIG] base_name_search_improved: Migration to 18.0 by lef-adhoc · Pull Request #3133 · OCA/server-tools

lef-adhoc · 2024-11-26T17:29:56Z

Migrated through this pr #2831

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

- Descriptor: change __openerp__.py file to __manifest__.py also update module version from 9.0.1.0.0 to 11.0.1.0.0 - Update README using guideline - Views: replace view tag openerp to odoo and rename files to match guideline - Models - update imports from openerp to odoo - remove enconding line # -*- coding: utf-8 -*- - update to make it compatible - remove use of SUPERUSER_ID use sudo instead. - rename class name to make it match with guideline. - update methods to match api used in version 11.0 - fix pylint errors - replace use of non exist self._model with self._name - use `Model `is not None instead of if `Model` this becuase the last one is a empty recordset and this one was evaluate to False and never was patching the method. - apply changes resquested/suggested in the PR by the reviewers.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/

florenciafrigieri2

Functional review ok!

nicolascol

LGTM

OCA-git-bot · 2025-01-14T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ced-adhoc

LGTM

ced-adhoc · 2025-02-13T14:43:44Z

Hi @pedrobaeza , could you please check this pr? thanks in advance!

pedrobaeza · 2025-02-13T15:11:28Z

/ocabot migration base_name_search_improved

A review by a PSC or maintainer is missing. cc @dreispt

dreispt · 2025-02-13T21:17:44Z

+        limit = limit or 0
+        results = []
+
+        for rec_name in all_names:


The comments for these two for and the following if are important to understand why this code is here, and should be kept. When the reason for a piece of code is not immediately obvious, is is helpful to have a comment hinting on the why.

I put back the original comments in the code, is that okay?

saxomanu · 2025-03-12T14:40:03Z

@lef-adhoc
When search in smart search (exemple in contact, search view), if no result, all record is display

lef-adhoc · 2025-03-13T20:04:10Z

@saxomanu Can you try now?
I also added the cache refresh in the search views when adding or removing the search from smart search.

saxomanu · 2025-03-13T20:51:10Z

@lef-adhoc Ok, thanx, it's all good now.

dreispt · 2025-03-16T18:31:37Z

/ocabot migration base_name_search_improved
/ocabot merge nobump

OCA-git-bot · 2025-03-16T18:31:45Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3133-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2025-03-16T18:37:45Z

Congratulations, your PR was merged at 00d737d. Thanks a lot for contributing to OCA. ❤️

dreispt and others added 30 commits November 26, 2024 12:41

base_name_search_improved: friendly and powerful name search

753cc90

Return all results from the several methods, ordered by best match

854870a

Test if additional domain is honored

306aedd

Honor name_search additional domain

6ee579d

Do not search on empty string. Fixes OCA#467

d98e419

Bump version

6315e0e

Fix small typo in readme

babf412

[9.0] MIG Improved Name Search

3bc208f

# Please enter the commit message for your changes. Lines starting

de30434

OCA Transbot updated translations from Transifex

4950bde

[UPD] Update base_name_search_improved.pot

08c0006

Translated using Weblate (Catalan)

de339ff

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

[UPD] Update base_name_search_improved.pot

bbb2e83

[UPD] README.rst

f3c9d85

Update translation files

90ed139

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] README.rst

2c38c85

[IMP] base_name_search_improved: black, isort, prettier

69ff83a

[IMP] base_name_search_improved: add v12 imp

82a4cd9

[IMP] base_name_search_improved: run pre commit again

e8d3ab9

[MIG] base_name_search_improved: Migration to 13.0

5b23563

[IMP] base_name_search_improved: patches

15a4e04

[14.0][MIG] base_name_search_improved

7873919

[UPD] Update base_name_search_improved.pot

3b0cb91

[UPD] README.rst

225eab4

[UPD] Update base_name_search_improved.pot

53d5283

[UPD] Update base_name_search_improved.pot

e88b000

[UPD] Update base_name_search_improved.pot

e7f76ae

[IMP] base_name_search_improved: pre-commit execution

71b74de

lef-adhoc mentioned this pull request Nov 26, 2024

Migration to version 18.0 #3047

Open

42 tasks

lef-adhoc force-pushed the 18.0-t-43308-lef branch 4 times, most recently from 5fda9a2 to ecc6179 Compare November 26, 2024 18:49

florenciafrigieri2 approved these changes Nov 29, 2024

View reviewed changes

nicolascol approved these changes Jan 14, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 14, 2025

ced-adhoc approved these changes Jan 29, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Feb 13, 2025

dreispt reviewed Feb 13, 2025

View reviewed changes

lef-adhoc force-pushed the 18.0-t-43308-lef branch from ecc6179 to 0230874 Compare February 18, 2025 02:02

[MIG] base_name_search_improved: Migration to 18.0

b0d04a0

lef-adhoc force-pushed the 18.0-t-43308-lef branch from 0230874 to b0d04a0 Compare March 13, 2025 19:55

dreispt approved these changes Mar 16, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 16, 2025

OCA-git-bot merged commit 6c8bc32 into OCA:18.0 Mar 16, 2025

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 16, 2025

Uh oh!

Uh oh!

Conversation

lef-adhoc commented Nov 26, 2024

Uh oh!

florenciafrigieri2 left a comment

Choose a reason for hiding this comment

Uh oh!

nicolascol left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 14, 2025

Uh oh!

ced-adhoc left a comment

Choose a reason for hiding this comment

Uh oh!

ced-adhoc commented Feb 13, 2025

Uh oh!

pedrobaeza commented Feb 13, 2025

Uh oh!

dreispt Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

lef-adhoc Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

saxomanu commented Mar 12, 2025

Uh oh!

lef-adhoc commented Mar 13, 2025

Uh oh!

saxomanu commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dreispt commented Mar 16, 2025

Uh oh!

OCA-git-bot commented Mar 16, 2025

Uh oh!

OCA-git-bot commented Mar 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

saxomanu commented Mar 13, 2025 •

edited

Loading