[17.0] [FIX] auditlog: Dismiss logging when not needed. - #3137
Merged
Conversation
rven
force-pushed
the
17.0-limit-logging
branch
from
December 4, 2024 13:08
c3ef867 to
dbb4207
Compare
rven
force-pushed
the
17.0-limit-logging
branch
4 times, most recently
from
December 4, 2024 14:36
b2c8180 to
48bed54
Compare
StefanRijnhart
requested changes
Dec 5, 2024
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
Thanks! This is literally a ticket in one of my backlogs 😃
The module name is included in the PR title, but not in the commit message. Can you add it there as well? And strictly speaking, [MOD] is not a valid tag listed in https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html#tag-and-module-name. I think this counts as a [FIX]. Please update the commit message on that point as well.
Do you think you can include a small test so that we can rule out a regression in the future?
rven
force-pushed
the
17.0-limit-logging
branch
3 times, most recently
from
December 5, 2024 11:57
688cdfd to
151c7ac
Compare
rven
force-pushed
the
17.0-limit-logging
branch
from
December 5, 2024 11:59
151c7ac to
cbf5478
Compare
rven
force-pushed
the
17.0-limit-logging
branch
from
December 5, 2024 11:59
cbf5478 to
23bb199
Compare
Contributor
|
This PR has the |
Member
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 0bf5429. Thanks a lot for contributing to OCA. ❤️ |
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Dec 27, 2024
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Dec 27, 2024
In OCA#3137 it is prevented to create auditlogs without log lines. In this particular test, it is tested that no log line is created for excluded fields. We would expect therefore that no auditlog is created after OCA#3137, but depending on the setup, an log line may be created for field phone_sanitized which is not an excluded field in the test. To fix this, the test is adapted to write another, non excluded field so that the auditlog is created in any case.
Member
lembregtse
added a commit
to lembregtse/server-tools
that referenced
this pull request
Dec 27, 2024
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-tools
that referenced
this pull request
Jan 13, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-tools
that referenced
this pull request
Jan 16, 2025
In OCA#3137 it is prevented to create auditlogs without log lines. In this particular test, it is tested that no log line is created for excluded fields. We would expect therefore that no auditlog is created after OCA#3137, but depending on the setup, an log line may be created for field phone_sanitized which is not an excluded field in the test. To fix this, the test is adapted to write another, non excluded field so that the auditlog is created in any case.
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-tools
that referenced
this pull request
Jan 20, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-tools
that referenced
this pull request
Jan 27, 2025
AaronFrans-Quatra
pushed a commit
to QuatraInternational/oca-server-tools
that referenced
this pull request
Mar 18, 2025
In OCA#3137 it is prevented to create auditlogs without log lines. In this particular test, it is tested that no log line is created for excluded fields. We would expect therefore that no auditlog is created after OCA#3137, but depending on the setup, an log line may be created for field phone_sanitized which is not an excluded field in the test. To fix this, the test is adapted to write another, non excluded field so that the auditlog is created in any case.
lembregtse
added a commit
to dynapps/server-tools
that referenced
this pull request
Sep 25, 2025
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Jan 2, 2026
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Jan 2, 2026
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Jan 2, 2026
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Jan 2, 2026
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fast logging is enabled on the audit log rules, empty records are created when fields are excluded from the list.
This results in a lot of empty unneeded log records, without any details.
This PR solves the issue so only a log record is created when needed.