[FIX] auditlog: adapt exclude fields test to #3137 - #3153
Merged
OCA-git-bot merged 1 commit intoDec 27, 2024
Conversation
In OCA#3137 it is prevented to create auditlogs without log lines. In this particular test, it is tested that no log line is created for excluded fields. We would expect therefore that no auditlog is created after OCA#3137, but depending on the setup, an log line may be created for field phone_sanitized which is not an excluded field in the test. To fix this, the test is adapted to write another, non excluded field so that the auditlog is created in any case.
StefanRijnhart
force-pushed
the
17.0-fix-auditlog-exclude_fields_test
branch
from
December 27, 2024 09:33
e4e02aa to
5a50d39
Compare
StefanRijnhart
marked this pull request as ready for review
December 27, 2024 09:38
hbrunn
approved these changes
Dec 27, 2024
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at c706e9b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3137 it is prevented to create auditlogs without log lines.
In this particular test, it is tested that no log line is created for excluded fields. We would expect therefore that no auditlog is created after #3137, but depending on the setup, an log line may be created for field
phone_sanitizedwhich is not an excluded field in the test.To fix this, the test is adapted to write another, non excluded field so that the auditlog is created in any case.
Fixes
Backported from #3054 by @lembregtse