[MIG] autovacuum_message_attachment: Migration to 17.0 - #3183
Open
GabbasovDinar wants to merge 33 commits into
Open
GabbasovDinar wants to merge 33 commits into
GabbasovDinar wants to merge 33 commits into
Conversation
… it is already present in other models
CRogos
reviewed
Feb 3, 2025
CRogos
left a comment
Contributor
There was a problem hiding this comment.
I am not using this module so I don't know how it works, but looks like a interesting and very powerfull module. Maybe add some more test coverage?
Also some commits could be squashed. Here some examples:
The changes so fare LGTM.
|
@CRogos Updated the readme to make the module behaviour more clear |
geomer198
approved these changes
Feb 5, 2025
Contributor
|
@Bearnard21 I apricate your work. Could you also do the squashing? |
Contributor
|
This PR has the |
GabbasovDinar
force-pushed
the
17.0-t4316-autovacuum_message_attachment-mig
branch
from
February 10, 2025 07:02
05a85c5 to
1f5f226
Compare
Member
Author
|
@CRogos Hi, I squashed some commits |
Contributor
|
There are still weblate and oca-ci commits which can be squashed. |
Translated using Weblate (Spanish (Argentina)) Currently translated at 100.0% (50 of 50 strings) Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
Selection of attachments through inheriting model can be useful if we want to purge attachments that are extended through another model. For example, shipping.label (from base_delivery_carrier_label) inherits from ir.attachment but the attachment itself is linked to the stock.picking model. By using inheriting_model defined to shipping.label and setting model_ids to stock.picking, we can safely select the attachments linked to stock.pickings that are shipping labels and avoid deleting any picking list or delivery note reports.
Currently translated at 100.0% (55 of 55 strings) Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
But allow it only if a file pattern is set, to avoid deleting all orphan attachments are some are auto-generated by Odoo
Translated using Weblate (Italian) Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
Translated using Weblate (Spanish) Currently translated at 67.3% (35 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/
Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/ [UPD] Update autovacuum_message_attachment.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/ [UPD] Update autovacuum_message_attachment.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/ [UPD] Update autovacuum_message_attachment.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/
GabbasovDinar
force-pushed
the
17.0-t4316-autovacuum_message_attachment-mig
branch
from
February 11, 2025 11:27
1f5f226 to
5c03d4e
Compare
|
@StefanRijnhart Could you please merge the PR. Thank you. |
dreispt
approved these changes
Apr 2, 2025
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Apr 2, 2025
Member
|
Merge seems stuck, let's try again /ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Apr 4, 2025
StefanRijnhart
requested changes
Apr 4, 2025
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
Hoping to fix the merge issue in #3254. Please don't merge until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.