[17.0][FIX] test.yml: prevent infinite loop of makepot commits - #3254
StefanRijnhart wants to merge 1 commit into
Conversation
the result will be the same in each of those jobs because the pot files will be generated for all the addons at once. If there are more than one test run with different sets of modules, and in one of those modules a field is added to the base model, the makepot jobs will have different outcomes and will keep on reverting each other's changes upon subsequent test runs.
|
Hi @StefanRijnhart , thank you for your contribution! Are you still working on this task? |
|
@ivs-cetmix Does it need more work? |
Not sure, I though you know this better) If you consider this done, then we can proceed with reviewing it. |
|
Please do! |
| include: | ||
| - container: ghcr.io/oca/oca-ci/py3.10-odoo17.0:latest | ||
| include: "database_cleanup" | ||
| makepot: "true" |
There was a problem hiding this comment.
Removing this one, no POT will be generated for database_cleanup AFAIK.
There was a problem hiding this comment.
I don't see any filtering in this code chain
https://github.com/OCA/oca-ci/blob/master/bin/oca_export_and_commit_pot#L15
https://github.com/acsone/click-odoo-contrib/blob/master/click_odoo_contrib/makepot.py#L155
https://github.com/acsone/click-odoo-contrib/blob/master/click_odoo_contrib/manifest.py#L39-L41
so it looks to me like a single run will generate POTs for all addons in the directory, regardless of include/exclude directives. Am I missing anything?
There was a problem hiding this comment.
Ah sorry, it does say 'for installed addons' in that first link, so you are right. Will amend.
|
@pedrobaeza Improved version included in #3345. |
Only run makepot once. The result will be equivalent in each of those jobs because the pot files will be generated for all the addons at once.
If there are more than one test run with different sets of modules, and in one of those modules a field is added to the base model, the makepot jobs will have different outcomes and will keep on reverting each other's changes upon subsequent test runs.