[18.0][mail_cleanup]FIX : respect method signature - #3333
Conversation
Ricardoalso
left a comment
There was a problem hiding this comment.
raise_exception should be passed to the super call https://github.com/OCA/server-tools/pull/3333/files#diff-77eade508f4aff5df5a30f49984ca899c9bc5b476d21d099e90945818d57f3ebL143
93176d2 to
bf5d43e
Compare
|
@Ricardoalso Thanks fixed |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3333-by-gurneyalex-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! The test issue causing the merge to fail is fixed in #3343
|
Hello @StefanRijnhart , your other PR fixing the merge is merged. Do you have any time to merge this one? |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 22ed5dc. Thanks a lot for contributing to OCA. ❤️ |
TypeError: FetchmailServer.fetch_mail() got an unexpected keyword argument 'raise_exception'