[18.0][FIX] auto_backup: pin paramiko for compatibility with pysftp - #3343
Merged
OCA-git-bot merged 1 commit intoAug 14, 2025
Merged
Conversation
This was referenced Aug 12, 2025
leemannd
approved these changes
Aug 12, 2025
ByteMeAsap
reviewed
Aug 12, 2025
| from datetime import datetime, timedelta | ||
| from unittest.mock import PropertyMock, patch | ||
|
|
||
| import pysftp |
Contributor
There was a problem hiding this comment.
Can you also make the same change at
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537 ``` File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module> import pysftp File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module> from paramiko import AgentKey, RSAKey, DSSKey ImportError: cannot import name 'DSSKey' from 'paramiko' ``` The import error was dropped silently, making the error show up as ``` File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module> class TestConnectionException(pysftp.ConnectionException): ^^^^^^ NameError: name 'pysftp' is not defined ```
StefanRijnhart
force-pushed
the
18.0-auto_backup-pin_paramiko
branch
from
August 12, 2025 09:30
8693b44 to
5fcb319
Compare
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 5a9d89c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537
The import error was dropped silently, making the error show up as