Skip to content

[18.0] auditlog: Log exports - #3338

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
tarteo:18-auditlog-export-data-
Sep 17, 2025
Merged

[18.0] auditlog: Log exports#3338
OCA-git-bot merged 1 commit into
OCA:18.0from
tarteo:18-auditlog-export-data-

Conversation

@tarteo

@tarteo tarteo commented Aug 6, 2025

Copy link
Copy Markdown
Member

The same as #2768 but for 18

@tarteo

tarteo commented Aug 6, 2025

Copy link
Copy Markdown
Member Author

Test error seems to be unrelated, please correct me if I'm wrong

tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Aug 6, 2025
@tarteo
[MIG] auditlog: Log exports OCA/server-tools#3338
f4082ad
@tarteo
tarteo force-pushed the 18-auditlog-export-data- branch 3 times, most recently from 9114c00 to c4c2c67 Compare August 6, 2025 10:10
tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Aug 6, 2025
@tarteo
[MIG] auditlog: Log exports OCA/server-tools#3338
25ace4e
ByteMeAsap
ByteMeAsap reviewed Aug 6, 2025
View reviewed changes
Comment thread auditlog/models/log.py
def show_res_ids(self):
self.ensure_one()
return {
"type": "ir.actions.act_window",

@ByteMeAsap ByteMeAsap Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add the model name? As currently it shows 'Unnamed' which is not too appealing

Image

@tarteo tarteo Aug 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done!

@tarteo
tarteo force-pushed the 18-auditlog-export-data- branch from 3eff140 to fb30aaf Compare August 6, 2025 11:42
ByteMeAsap
ByteMeAsap approved these changes Aug 6, 2025
View reviewed changes

@ByteMeAsap ByteMeAsap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Great Stuff!!

@StefanRijnhart

StefanRijnhart commented Aug 12, 2025

Copy link
Copy Markdown
Member

Tests are fixed in #3343

@tarteo
tarteo force-pushed the 18-auditlog-export-data- branch 2 times, most recently from 9fe7746 to b141dd3 Compare September 9, 2025 09:20
@tarteo
[18.0] auditlog: Log exports
3f5f7df 
[IMP] auditlog: Add name to action for UX
@tarteo
tarteo force-pushed the 18-auditlog-export-data- branch from b141dd3 to 3f5f7df Compare September 9, 2025 09:41
@tarteo

tarteo commented Sep 9, 2025

Copy link
Copy Markdown
Member Author

@StefanRijnhart Thanks! I rebased the branch and the tests are passing now 🥳

@OCA-git-bot

OCA-git-bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tarteo

tarteo commented Sep 17, 2025

Copy link
Copy Markdown
Member Author

@StefanRijnhart can we merge this, please?

@tarteo tarteo closed this Sep 17, 2025
@tarteo tarteo reopened this Sep 17, 2025
@StefanRijnhart

StefanRijnhart commented Sep 17, 2025

Copy link
Copy Markdown
Member

@tarteo Yes, with the 16.0 review finalized, we can.

/ocabot merge major

@OCA-git-bot

OCA-git-bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3338-by-StefanRijnhart-bump-major, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 74e216e into OCA:18.0 Sep 17, 2025
10 of 11 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at df91b5b. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart StefanRijnhart mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes
+2 more reviewers
@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes
@ByteMeAsap ByteMeAsap ByteMeAsap approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tarteo @StefanRijnhart @OCA-git-bot @MiquelRForgeFlow @ByteMeAsap