Skip to content

[16.0][FIX] auto_backup: pin paramiko for compatibility with pysftp - #3344

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
StefanRijnhart:16.0-auto_backup-pin_paramiko
Aug 20, 2025
Merged

OCA-git-bot merged 1 commit into
OCA:16.0from
StefanRijnhart:16.0-auto_backup-pin_paramiko

Conversation

@StefanRijnhart

Copy link
Copy Markdown
Member

Port of #3343

paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537

File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module>
    import pysftp
  File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module>
    from paramiko import AgentKey, RSAKey, DSSKey
ImportError: cannot import name 'DSSKey' from 'paramiko'

The import error was dropped silently, making the error show up as

File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module>
    class TestConnectionException(pysftp.ConnectionException):
                                  ^^^^^^
NameError: name 'pysftp' is not defined

@StefanRijnhart StefanRijnhart added this to the 16.0 milestone Aug 12, 2025
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module>
    import pysftp
  File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module>
    from paramiko import AgentKey, RSAKey, DSSKey
ImportError: cannot import name 'DSSKey' from 'paramiko'
```

The import error was dropped silently, making the error show up as

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module>
    class TestConnectionException(pysftp.ConnectionException):
                                  ^^^^^^
NameError: name 'pysftp' is not defined
```
@StefanRijnhart
StefanRijnhart force-pushed the 16.0-auto_backup-pin_paramiko branch from 58db85e to 5c89c46 Compare August 12, 2025 09:32

@ByteMeAsap ByteMeAsap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3344-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit b80ffc2 into OCA:16.0 Aug 20, 2025
9 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c6e4c9a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants