[17.0][FIX] auditlog: fix caching; [ADD] test_auditlog - #3373
Merged
OCA-git-bot merged 3 commits intoOct 1, 2025
Merged
Conversation
StefanRijnhart
force-pushed
the
17.0-auditlog-fix-cache_sanitation
branch
from
September 16, 2025 14:31
e150221 to
a936a1d
Compare
StefanRijnhart
marked this pull request as draft
September 16, 2025 16:07
StefanRijnhart
force-pushed
the
17.0-auditlog-fix-cache_sanitation
branch
2 times, most recently
from
September 16, 2025 19:41
fff8e4d to
7cee60f
Compare
StefanRijnhart
marked this pull request as ready for review
September 16, 2025 19:47
MiquelRForgeFlow
approved these changes
Sep 17, 2025
Though TransactionCase rolls back database changes, it does not call `unlink` on `auditlog.rule` records, meaning that `unsubscribe` is never called to unpatch model methods. This causes subsequent tests in other modules to unexpectedly execute patched methods. This commit adds the `AuditLogRuleCommon` test class in an attempt to identify and prevent patched methods from contaminating the test environment.
StefanRijnhart
force-pushed
the
17.0-auditlog-fix-cache_sanitation
branch
from
September 24, 2025 17:30
7cee60f to
b77880f
Compare
Contributor
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 9680155. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #3371
Fix caching and add a dedicated test module to run tests on the accounting models.
Fixes creating credit notes with audit rules on account.move.line, writing taxes on products as a user that does not have access to all companies for which there are taxes on the product, and more.
Fixes #3308, #3224, #2561, #2554
Includes a port of #3364.