[16.0][FIX] auditlog: fix caching; [ADD] test_auditlog - #3371
Conversation
e03ad0e to
24bbfcc
Compare
24bbfcc to
15a1e67
Compare
NL66278
left a comment
There was a problem hiding this comment.
👍 LGTM and extensive unit tests
|
Setting this to draft as I've encountered an issue swapping out the cache as is done here. |
15a1e67 to
dbf5d80
Compare
|
Fixed now. Issue is explained in the docstring of the new context manager. |
|
@StefanRijnhart The contextmanager seems to be a quite clean solution. Maybe useful in more places. |
dbf5d80 to
23e8e4e
Compare
|
Rebased to fix conflicts |
CasVissers-360ERP
left a comment
There was a problem hiding this comment.
Functional review. Fixed the issue for me.
23e8e4e to
c6aedd0
Compare
|
Rebased after the merge of #3364, which was originally included here. |
|
This PR has the |
|
@thomaspaulb Could you merge this one? |
amh-mw
left a comment
There was a problem hiding this comment.
Code review only, LGTM. Though superior to cache poisoning, I'm curious how much slower this makes full audit logging
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Thanks for this! 👍
/ocabot merge patch
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 75d6c16. Thanks a lot for contributing to OCA. ❤️ |
|
See #3409 for an important fix for this change. |
Fix caching and add a dedicated test module to run tests on the accounting models.
Fixes creating credit notes with audit rules on account.move.line, writing taxes on products as a user that does not have access to all companies for which there are taxes on the product, and more.
Fixes #3308, #3224, #2561, #2554