Conversation
Member
|
BTW your review on #3371 would be much appreciated. |
Though TransactionCase rolls back database changes, it does not call `unlink` on `auditlog.rule` records, meaning that `unsubscribe` is never called to unpatch model methods. This causes subsequent tests in other modules to unexpectedly execute patched methods. This commit adds the `AuditLogRuleCommon` test class in an attempt to identify and prevent patched methods from contaminating the test environment.
amh-mw
force-pushed
the
18.0-test-contamination
branch
from
September 24, 2025 21:10
8a9caf7 to
675ffa7
Compare
Member
|
Merged with #3374. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though TransactionCase rolls back database changes, it does not call
unlinkonauditlog.rulerecords, meaning thatunsubscribeis never called to unpatch model methods. This causes subsequent tests in other modules to unexpectedly execute patched methods.This commit adds the
AuditLogRuleCommontest class in an attempt to identify and prevent patched methods from contaminating the test environment.Forward port of 16.0 #3364