[19.0][MIG] auditlog: Migration to 19.0 by lembregtse · Pull Request #3391 · OCA/server-tools

lembregtse · 2025-09-25T06:23:42Z

No description provided.

… module

…file

… ones to make overridding easier

…ther minor fixes

…itlog.log' model (standard 'create_date' field is used instead)

…S.txt file removed

…t never used

…ail data - if any - are migrated during the installation)

… a field is deleted (e.g. migration)

… 'field_description' fields changed into related fields

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Currently translated at 97.7% (85 of 87 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

…ecuted by an onchange function

[IMP] auditlog: Add name to action for UX

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

rven · 2025-09-25T08:51:21Z

@legalsylvain It seems that the CI pipelines need to include the --with-demo option.
Odoo doesn't install demo by default anymore.

Wh1spr · 2025-10-04T20:12:46Z

+            vals = {
+                "name": httprequest.path,
+                "root_url": httprequest.url_root,
+                "user_id": request.uid,


This will trigger a warning: DeprecationWarning: Since 19.0, use request.env.uid directly
There may be more instances of this, I did not check.

Wh1spr · 2025-10-04T20:13:12Z

+                "root_url": httprequest.url_root,
+                "user_id": request.uid,
+                "http_session_id": http_session_model.current_http_session(),
+                "user_context": request.context,


This will trigger a warning: DeprecationWarning: Since 19.0, use request.env.context directly
There may be more instances of this, I did not check.
For request, this also applies to request.cr -> request.env.cr

Fixed + added some test scenario's

rven · 2025-10-09T13:25:09Z

@legalsylvain It seems that the CI pipelines need to include the --with-demo option. Odoo doesn't install demo by default anymore.

Fixed!

sbidoul · 2025-10-11T11:12:39Z

/ocabot migration auditlog

DucTruongKomit

Could you help to solve, so it can be merged, please? @lembregtse
Thank you

DucTruongKomit · 2025-10-14T04:33:24Z

+            return False
+        httpsession = request.session
+        if httpsession:
+            existing_session = self.search(


I suggest we can use search_fetch which is available in odoo 18 to improve the perfomance.

DucTruongKomit · 2025-10-14T04:40:33Z

+        if "model_id" in vals:
+            if not vals["model_id"]:


Suggested change

if "model_id" in vals:

if not vals["model_id"]:

if "model_id" in vals and not vals["model_id"]:

DucTruongKomit · 2025-10-14T04:42:37Z

+    _description = "Auditlog - Log details (fields updated)"
+
+    field_id = fields.Many2one(
+        "ir.model.fields", ondelete="set null", string="Field", index=True


Suggested change

"ir.model.fields", ondelete="set null", string="Field", index=True

"ir.model.fields", ondelete="set null", index=True

DucTruongKomit · 2025-10-14T04:45:23Z

+        "ir.model.fields", ondelete="set null", string="Field", index=True
+    )
+    log_id = fields.Many2one(
+        "auditlog.log", string="Log", ondelete="cascade", index=True


Suggested change

"auditlog.log", string="Log", ondelete="cascade", index=True

"auditlog.log", ondelete="cascade", index=True

DucTruongKomit · 2025-10-14T04:47:46Z

+        if "field_id" in vals:
+            if not vals["field_id"]:


Suggested change

if "field_id" in vals:

if not vals["field_id"]:

if "field_id" in vals and not vals["field_id"]:

DucTruongKomit · 2025-10-14T04:49:43Z

+        deadline = datetime.now() - timedelta(days=days)
+        data_models = ("auditlog.log", "auditlog.http.request", "auditlog.http.session")
+        for data_model in data_models:
+            records = self.env[data_model].search(


the same comment above using search_fetch

StefanRijnhart

Can you rebase? There has been quite some changes in this module during and after the OCA days this year.
Also, if you are interested in this module, maybe you would like to review of some of the other (unmerged) recent PRs against this module.

adnankkapasi · 2025-12-10T12:27:25Z

@lembregtse Could you please do the needful, so that this PR gets merged?
Thanks in advance

adnankkapasi · 2025-12-30T05:51:52Z

@lembregtse Could you please do the needful, so that this PR gets merged? Thanks in advance

@lembregtse Any update?

StefanRijnhart · 2026-01-02T13:52:24Z

Given that my recent changes in auditlog (not yet included here) are meddling with Odoo cache internals, which have been refactored completely in Odoo 19, I will be having a go at this one in the next couple of days.

StefanRijnhart · 2026-01-02T21:27:31Z

Superseded by #3483

sebalix and others added 30 commits September 24, 2025 13:31

[ADD] Module 'auditlog' - A substitute to the deprecated 'audittrail'…

465475e

… module

[FIX] Module 'auditlog' - Fix some flake8 errors

384bcef

[FIX] Module 'auditlog' - Put the module description in a README.rst …

b33ef52

…file

[ADD] Module 'auditlog' - 'auditlog.pot' file added

54428b2

[IMP] Module 'auditlog' - Split the 'create_logs()' method in several…

1d1c71b

… ones to make overridding easier

[IMP] Module 'auditlog' - Clean up vim lines

0a45948

[IMP] Module 'auditlog' - Add 'name' attributes on some filters and o…

8aaa060

…ther minor fixes

[IMP] Module 'auditlog' - Removed the 'timestamp' field from the 'aud…

bf5b5bb

…itlog.log' model (standard 'create_date' field is used instead)

[IMP] Module 'auditlog' - README.rst updated (based on the OCA template)

90aa42a

[FIX] Module 'auditlog' - 'time' module imported but unused

b003b45

[IMP] ignore rules for nonexisting objects

394e205

[ADD] init hook to migrate from audittrail

9c2919a

[FIX] also migrate id sequences

a0d7498

[IMP] Module 'auditlog' - Contributors updated in README.rst + AUTHOR…

b8105de

…S.txt file removed

[ADD] change xmlids of legacy rules to point to auditlog.rule

9cae51e

[IMP] use new import of _, SUPERUSER_ID

ad4c39a

[ADD] allow overriding modules to pass additional log values

a356831

[IMP] cache model and field ids

8a7438f

[IMP] don't make a temporary copy of dict keys

d6966e2

[FIX] don't reset caches in register_hook

d8abb64

[ADD] pass old_values to create_log when deleting a record

f10c525

[FIX] cope with no additional log values

8a82e03

[ADD] tests

6c22c54

[FIX] Module 'auditlog' - local variable 'ir_model' is assigned to bu…

b52c52e

…t never used

[IMP] use a model for test that is not influenced by the mail module

ba8c96e

[FIX] Module 'auditlog' - Remove 'active' field from __openerp__.py

b288694

[IMP] Module 'auditlog' - README.rst updated (inform that the audittr…

a953824

…ail data - if any - are migrated during the installation)

[IMP] Module 'auditlog' - Useless lines of code removed

432bc66

[IMP] Module 'auditlog' - Autoremove 'auditlog.log.line' records when…

0f7734e

… a field is deleted (e.g. migration)

[IMP] Module 'auditlog' - Model 'auditlog.log.line', 'field_name' and…

98c3c54

… 'field_description' fields changed into related fields

lembregtse and others added 12 commits September 24, 2025 13:31

[FIX] auditlog: adapt exclude fields test to OCA#3137

f09c4f6

[UPD] Update auditlog.pot

8c3af62

[BOT] post-merge updates

b912a36

Update translation files

1865243

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Translated using Weblate (Turkish)

8a58642

Currently translated at 97.7% (85 of 87 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/tr/

[FIX] auditlog rule: Control the write function in the models when ex…

615fc7e

…ecuted by an onchange function

[BOT] post-merge updates

d9d53bd

[18.0] auditlog: Log exports

158312f

[IMP] auditlog: Add name to action for UX

[UPD] Update auditlog.pot

133a313

[BOT] post-merge updates

e7f6375

Update translation files

f5f582d

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/

Translated using Weblate (Italian)

7c6ec68

Currently translated at 100.0% (91 of 91 strings) Translation: server-tools-18.0/server-tools-18.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog/it/

lembregtse force-pushed the 19.0-mig-auditlog branch from 19601ca to 715e3aa Compare September 25, 2025 08:12

Wh1spr suggested changes Oct 4, 2025

View reviewed changes

rven force-pushed the 19.0-mig-auditlog branch from 715e3aa to 628c510 Compare October 9, 2025 13:22

[MIG] auditlog: Migration to 19.0

acf373c

rven force-pushed the 19.0-mig-auditlog branch from 628c510 to acf373c Compare October 9, 2025 13:24

rven mentioned this pull request Oct 9, 2025

Migration to version 19.0 #3400

Open

43 tasks

OCA-git-bot added this to the 19.0 milestone Oct 11, 2025

DucTruongKomit suggested changes Oct 14, 2025

View reviewed changes

StefanRijnhart reviewed Oct 28, 2025

View reviewed changes

StefanRijnhart mentioned this pull request Jan 2, 2026

[19.0][MIG] auditlog: Migration to 19.0 #3483

Merged

StefanRijnhart closed this Jan 2, 2026

	if "model_id" in vals:
	if not vals["model_id"]:
	if "model_id" in vals and not vals["model_id"]:

	"ir.model.fields", ondelete="set null", string="Field", index=True
	"ir.model.fields", ondelete="set null", index=True

	"auditlog.log", string="Log", ondelete="cascade", index=True
	"auditlog.log", ondelete="cascade", index=True

	if "field_id" in vals:
	if not vals["field_id"]:
	if "field_id" in vals and not vals["field_id"]:

Uh oh!

Uh oh!

Conversation

lembregtse commented Sep 25, 2025

Uh oh!

rven commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rven commented Oct 9, 2025

Uh oh!

sbidoul commented Oct 11, 2025

Uh oh!

DucTruongKomit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

adnankkapasi commented Dec 10, 2025

Uh oh!

adnankkapasi commented Dec 30, 2025

Uh oh!

StefanRijnhart commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

DucTruongKomit left a comment •

edited

Loading

StefanRijnhart commented Jan 2, 2026 •

edited

Loading