[19.0][MIG] database_cleanup: Migration to 19.0 by bizzappdev · Pull Request #3453 · OCA/server-tools

bizzappdev · 2025-11-25T11:45:08Z

No description provided.

avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change guewen.baconnier@camptocamp.com-20140203103254-v1mzu2uib047xb9h, wrong lines replaced...

raw SQL query (but never read afterwards). Workaround for lp:1277899 [FIX] Preserve dangling workflow table which is in use [RFR] Group models per table when detecting columns to purge to prevent problems with models sharing the same table [ADD] Allow purging of dangling data entries [FIX] Data purging now working [IMP] Docstrings [FIX] Label [FIX] Catch attempt to unlink field from nonexisting model [RFR] Flake8

[CHG] database_cleanup: move description to README.rst

[IMP] order wizard lines by name [IMP] deal with modules whose models can't be loaded [IMP] double quotes for docstring [FIX] use exists query instead of huge in list [IMP] hide unnecessary buttons in wizard II [IMP] readability [FIX] cope with purging nonexisting models

[IMP] adaptto upstream changes

[ADD] test purging modules [ADD] test purging tables

Fixes OCA#505

[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests

* [FIX] database_cleanup: Isolate build * Isolate `database_cleanup` into its own build in Travis file to fix OCA#689 * [FIX] database_cleanup: Remove KeyError assertion * Remove KeyError assertion in tests due to PR in comment being merged

* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties

Using new base model inheritance.

[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can

Update version number Use correct import Update .pot to match new syntax Adapt icon to fontawesome Add models description Rename field external id to new syntax <model>__<field>

cf discussion on OCA#1408

To match the new database_cleanup.pot

Following odoo/odoo@54238c88e85d6e a Many2many may have no relation This avoids having a None record in the list (which is problematic with the NOT IN clause) https://wiki.postgresql.org/wiki/Don't_Do_This#Don.27t_use_NOT_IN

Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/it/

nicomacr · 2025-11-26T13:49:51Z

Hi @bizzappdev,
I've started the migration on this PR
I need this module to be installable and this one is not able to install yet.

bizzappdev · 2025-11-27T06:30:07Z

We are working on the migration. And almost everything is migrated.
QA guys are testing. Once it is ready within 1 or 2 days, we will commit the migrated version.
@nicomacr

bizzappdev · 2025-12-02T05:32:47Z

@nicomacr modules is migrated and ready for the review.

nicomacr

LGTM

twalter-c2c

Looks good in general. I am about to test the module functionally. I noticed that you did some refactoring - you moved code blocks for each model to a dedicated file, thank you for that. However, I would really appreciate it if you could keep the refactoring in a separate commit to ease reviewing the migration changes.

Sign in to view

+        yield env


 # Use post_install to get all models loaded more info: odoo/odoo#13458


twalter-c2c · 2025-12-08T13:03:30Z



-class TestIdentifierAdapter(TransactionCase):
+class TestIdentifierAdapter(BaseCommon):


Is there a need to use the BaseCommon here? Maybe you can make use of disabling tracking: cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) as advised here instead? I believe that disabled tracking is recommended for all tests.

twalter-c2c · 2025-12-08T16:31:47Z

It would be great if you could rebase on top of this PR #3273 since it got merged.

…l table

instead of 'Purge this model' everywhere.

Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/

twalter-c2c

Thank you for the updates. It looks good now.

OCA-git-bot · 2025-12-10T15:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk · 2025-12-12T08:34:11Z

/ocabot merge nobump

OCA-git-bot · 2025-12-12T08:34:18Z

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3453-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-12-12T08:37:38Z

Congratulations, your PR was merged at cb60ff7. Thanks a lot for contributing to OCA. ❤️

Stefan Rijnhart and others added 30 commits October 27, 2025 12:56

[ADD] Database cleanup module

3c73a74

remove relations when purging models

438d397

avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change guewen.baconnier@camptocamp.com-20140203103254-v1mzu2uib047xb9h, wrong lines replaced...

[CHG] Migration to 8.0

eb78a74

[CHG] database_cleanup: move description to README.rst

Missing templates and translations added

8f0bd9a

[ADD] allow to clean up menus

b8100d0

[IMP] allow to select lines to purge in a tree view

04e0db9

[IMP] adaptto upstream changes

[ADD] migrate database_cleanup

b04ca17

[ADD] test purging modules [ADD] test purging tables

[RFR] Explicit access rights so that tests can run

1a2492f

Fixes OCA#505

[FIX] purge uninstalled uninstallable modules instead of deleting

fcd77fc

[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests

[IMP] call the button handler to also purge reverse dependencies

2547b91

[FIX] don't crash if an xmlid refers to a nonexisting field (OCA#559)

23d6ae0

[FIX] clean database menus was proposing good menus to purge (OCA#562)

548e889

fixes OCA#587

4caffc9

[FIX] database_cleanup: Fix test (OCA#612)

6ba31ae

[MIG] database_cleanup: Migration to version 10.0

643f2af

Using new base model inheritance.

[FIX] really uninstall modules and avoid a crash on cached data

e6ca976

[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can

[ADD] [database_cleanup] migrate to 11.0

94ecde2

database_cleanup_fix_runbot_links

e8be12e

Global pylint cleanup

ef895a7

[FIX] don't destroy values when there are empty default properties

cca90db

[FIX] show the redundant property's res_id, not the default one's

277f9f4

[IMP] don't break on properties pointing to unknown models

8016e31

[MIG] database_cleanup: migration to 12.0

586dbd8

Update version number Use correct import Update .pot to match new syntax Adapt icon to fontawesome Add models description Rename field external id to new syntax <model>__<field>

[FIX] database_cleanup: exclude password fields

8a01de8

cf discussion on OCA#1408

[I18N] database_cleanup: reflect changes to en.po

5f61f87

To match the new database_cleanup.pot

[FIX] database_cleanup: filter on many2many fields

6a44eeb

Following odoo/odoo@54238c88e85d6e a Many2many may have no relation This avoids having a None record in the list (which is problematic with the NOT IN clause) https://wiki.postgresql.org/wiki/Don't_Do_This#Don.27t_use_NOT_IN

Translated using Weblate (Italian)

5668eb5

Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/it/

bizzappdev marked this pull request as ready for review December 1, 2025 14:37

nicomacr approved these changes Dec 2, 2025

View reviewed changes

twalter-c2c reviewed Dec 8, 2025

View reviewed changes

StefanRijnhart and others added 5 commits December 9, 2025 10:41

[IMP] database_cleanup: add table purge blacklist with known non-mode…

46e368a

…l table

[IMP] database_cleanup: set appropriate labels in each purge view

e0f9db5

instead of 'Purge this model' everywhere.

Translated using Weblate (German)

19a7bb9

Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/de/

Update translation files

8af4eda

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/

[IMP] database_cleanup: pre-commit auto fixes

9a5810d

bizzappdev marked this pull request as draft December 9, 2025 05:35

bizzappdev force-pushed the 19.0-mig-database_cleanup-BAD branch from 73135f2 to 9a5810d Compare December 9, 2025 05:52

bizzappdev added 2 commits December 9, 2025 20:17

[MIG] database_cleanup: Migration to 19.0

8a176f5

[IMP] database_cleanup: Improved the file structure

218d2af

twalter-c2c approved these changes Dec 10, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 10, 2025

bizzappdev marked this pull request as ready for review December 11, 2025 07:21

OCA-git-bot added the bot is merging ⏳ label Dec 12, 2025

OCA-git-bot merged commit f2284c5 into OCA:19.0 Dec 12, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 12, 2025

StefanRijnhart mentioned this pull request Aug 21, 2026

Migration to version 19.0 #3400

Open

43 tasks

		yield env


		# Use post_install to get all models loaded more info: odoo/odoo#13458



		class TestIdentifierAdapter(TransactionCase):
		class TestIdentifierAdapter(BaseCommon):

Uh oh!

Uh oh!

Conversation

bizzappdev commented Nov 25, 2025

Uh oh!

nicomacr commented Nov 26, 2025

Uh oh!

bizzappdev commented Nov 27, 2025

Uh oh!

bizzappdev commented Dec 2, 2025

Uh oh!

nicomacr left a comment

Choose a reason for hiding this comment

Uh oh!

twalter-c2c left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

twalter-c2c Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

twalter-c2c commented Dec 8, 2025

Uh oh!

twalter-c2c left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 10, 2025

Uh oh!

simahawk commented Dec 12, 2025

Uh oh!

OCA-git-bot commented Dec 12, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants