Conversation
avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change guewen.baconnier@camptocamp.com-20140203103254-v1mzu2uib047xb9h, wrong lines replaced...
raw SQL query (but never read afterwards). Workaround for
lp:1277899
[FIX] Preserve dangling workflow table which is in use
[RFR] Group models per table when detecting columns to purge
to prevent problems with models sharing the same table
[ADD] Allow purging of dangling data entries
[FIX] Data purging now working
[IMP] Docstrings
[FIX] Label
[FIX] Catch attempt to unlink field from nonexisting model
[RFR] Flake8
[CHG] database_cleanup: move description to README.rst
[IMP] order wizard lines by name [IMP] deal with modules whose models can't be loaded [IMP] double quotes for docstring [FIX] use exists query instead of huge in list [IMP] hide unnecessary buttons in wizard II [IMP] readability [FIX] cope with purging nonexisting models
[IMP] adaptto upstream changes
[ADD] test purging modules [ADD] test purging tables
[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests
* [FIX] database_cleanup: Isolate build * Isolate `database_cleanup` into its own build in Travis file to fix OCA#689 * [FIX] database_cleanup: Remove KeyError assertion * Remove KeyError assertion in tests due to PR in comment being merged
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
Using new base model inheritance.
[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can
Update version number Use correct import Update .pot to match new syntax Adapt icon to fontawesome Add models description Rename field external id to new syntax <model>__<field>
cf discussion on OCA#1408
Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/
Currently translated at 100.0% (84 of 84 strings) Translation: server-tools-17.0/server-tools-17.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/it/
Currently translated at 100.0% (84 of 84 strings) Translation: server-tools-17.0/server-tools-17.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/zh_CN/
Currently translated at 100.0% (84 of 84 strings) Translation: server-tools-17.0/server-tools-17.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/
Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/it/
Currently translated at 100.0% (75 of 75 strings) Translation: server-tools-18.0/server-tools-18.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup/de/
There was a problem hiding this comment.
Pull request overview
This PR migrates the database_cleanup module from version 18.0 to 19.0, maintaining its functionality for cleaning orphaned database elements left by uninstalled modules or database upgrades.
Key changes:
- Updated version number from 18.0 to 19.0 in manifest
- Added comprehensive translation files for multiple languages (Croatian, Hebrew, Galician variants, French variants, Finnish, Persian, Basque, Estonian, Spanish Venezuelan)
- Updated documentation references to version 19.0
Reviewed changes
Copilot reviewed 38 out of 115 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
database_cleanup/__manifest__.py |
Version updated to 19.0.1.0.0 |
database_cleanup/__init__.py |
Module initialization file added |
database_cleanup/README.rst |
Documentation updated with 19.0 references |
database_cleanup/i18n/*.po |
Translation files added for 10 different locales |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
nicomacr
force-pushed
the
19.0-mig-database_cleanup
branch
3 times, most recently
from
November 26, 2025 12:55
89c752e to
1ea7a2e
Compare
nicomacr
force-pushed
the
19.0-mig-database_cleanup
branch
from
November 26, 2025 12:58
1ea7a2e to
51dc8c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.