Skip to content

[17.0][MIG] spreadsheet_oca: Migration to 17.0 - #40

Closed
FernandoRomera wants to merge 139 commits into
OCA:17.0from
FernandoRomera:17.0-mig-spreadsheet_oca
Closed

FernandoRomera wants to merge 139 commits into
OCA:17.0from
FernandoRomera:17.0-mig-spreadsheet_oca

Conversation

@FernandoRomera

Copy link
Copy Markdown

No description provided.

etobella and others added 30 commits July 26, 2024 06:05
With this change we are adding an extra layer of security. Without it, any user was able to sniff how all happened using something like:

    const any_spreadsheet_id = 1234;
    const channel = "spreadsheet_oca;spreadsheet.spreadsheet;" + any_spreadsheet_id;
    bus_service.addChannel(channel);
    bus_service.addEventListener("spreadsheet_oca", (message) => /* every revision arrives here */

With the change, we verify the access to the model with a similar logic to `web_editor` fields
@FernandoRomera
FernandoRomera force-pushed the 17.0-mig-spreadsheet_oca branch 2 times, most recently from 754e885 to 993cab6 Compare July 26, 2024 04:55
@FernandoRomera FernandoRomera mentioned this pull request Jul 26, 2024
2 tasks
@FernandoRomera
FernandoRomera force-pushed the 17.0-mig-spreadsheet_oca branch 5 times, most recently from c61f967 to 39fd295 Compare July 26, 2024 06:17
@pedrobaeza

Copy link
Copy Markdown
Member

Please squash administrative commits into the relevant ones, like this:

imagen

In fact, all that .pot files updates are due to a bug in Odoo codebase that was fixed in 17.0 (and backported to 16.0 when we warned about it: odoo/odoo#172896).

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration spreadsheet_oca

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 26, 2024
@FernandoRomera
FernandoRomera force-pushed the 17.0-mig-spreadsheet_oca branch 5 times, most recently from dee2451 to 21abae1 Compare July 30, 2024 08:03
@FernandoRomera
FernandoRomera force-pushed the 17.0-mig-spreadsheet_oca branch from 21abae1 to a2306cb Compare July 30, 2024 08:10
@mnoukrati

Copy link
Copy Markdown

I tried to the module, but I have an error when I try to add to spreadsheet :
1- from the sale order list view, click on "Add to spreadsheet"
2- On the wizard, Iselect "Create spreadsheet" and Click on "OK"
3- The error is shown

UncaughtPromiseError
Promesse non interceptée > Component is destroyed

Error: Component is destroyed
at ORM.call (http://5.196.100.187:8069/web/assets/0a471e1/web.assets_web.min.js:3995:122)
at SpreadsheetTransportService.sendMessage (http://5.196.100.187:8069/web/assets/0dd4c11/spreadsheet.o_spreadsheet.min.js:10332:31)
at Session._move (http://5.196.100.187:8069/web/assets/0dd4c11/spreadsheet.o_spreadsheet.min.js:5944:160)
at later (http://5.196.100.187:8069/web/assets/0dd4c11/spreadsheet.o_spreadsheet.min.js:78:160

@lauradiaz22

Copy link
Copy Markdown

Good morning, I have checked at a functional level the migration and I have found the following error:

TypeError: env.raiseError is not a function
at paste$1 (http://oca-spreadsheet-17-0-pr40-a2306cbb0b54.runboat.odoo-community.org/web/assets/f72c4ab/spreadsheet.o_spreadsheet.min.js:1687:195)
at async Menu.activateMenu (http://oca-spreadsheet-17-0-pr40-a2306cbb0b54.runboat.odoo-community.org/web/assets/f72c4ab/spreadsheet.o_spreadsheet.min.js:1203:39)

I get this error when I try to copy and paste a cell into a spreadsheet. Exactly the error appears when I apply the paste function. Thanks in advance.

@RFoerster

RFoerster commented Nov 21, 2024

Copy link
Copy Markdown

Hi Fernando, first of all - thank you so much for your work!
I tested the module and found an issue: Deleting Spreadsheets is not possible. To reproduce: Create a spreadsheet with multiple sheets. On the bottom at the spreadsheet name click onto the arrow and click delete. I get the following error:

OwlError: Cannot make the given value reactive
    Error: Cannot make the given value reactive
        at reactive (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:975:147)
        at useState (https:///localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:999:8)
        at Dialog.setup (https:///localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:2090:1434)
        at Dialog.setup (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:2100:337)
        at new ComponentNode (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:1002:202)
        at https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:1546:6
        at SpreadsheetRenderer.template (eval at compile (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:1502:374), <anonymous>:41:13)
        at RootFiber._render (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:940:96)
        at RootFiber.render (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:939:6)
        at ComponentNode.render (https://localhost:8069/web/assets/2/b506e7e/web.assets_web.min.js:1015:56)


I tried debugging it but failed unfortunately in fixing it. I was able to figure out that within the Dialog Component (of Odoo Base)

this.data = useState(this.env.dialogData

is called but dialogData is not set.

Sorry for not being much more help!

@sidi-med3

Copy link
Copy Markdown

Hello , I tried to migrate to version 17, but when I click on the pivot table icon, it shows me the following error: "UncaughtPromiseError > OwlError
Uncaught Promise > An error occured in the owl lifecycle (see this Error's "cause" property)
OwlError: An error occured in the owl lifecycle (see this Error's "cause" property)
Error: An error occured in the owl lifecycle (see this Error's "cause" property)
at handleError (http://localhost:8071/web/assets/debug/web.assets_web.js:9163:35) (/web/static/lib/owl/owl.js:1579)
at App.handleError (http://localhost:8071/web/assets/debug/web.assets_web.js:13483:20) (/web/static/lib/owl/owl.js:5899)
at Fiber._render (http://localhost:8071/web/assets/debug/web.assets_web.js:9316:30) (/web/static/lib/owl/owl.js:1732)
at Fiber.render (http://localhost:8071/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721)
at ComponentNode.initiateRender (http://localhost:8071/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)

Caused by: TypeError: ctx.getSpreadsheetInsertionTooltip is not a function
at PivotRenderer.template (eval at compile (http://localhost:8071/web/assets/debug/web.assets_web.js:13198:20), :26:54) (/web/static/lib/owl/owl.js:5614)
at App.callTemplate (http://localhost:8071/web/assets/debug/web.assets_web.js:10902:50) (/web/static/lib/owl/owl.js:3318)
at PivotRenderer.template (eval at compile (http://localhost:8071/web/assets/debug/web.assets_web.js:13198:20), :27:10) (/web/static/lib/owl/owl.js:5614)
at Fiber._render (http://localhost:8071/web/assets/debug/web.assets_web.js:9313:38) (/web/static/lib/owl/owl.js:1729)
at Fiber.render (http://localhost:8071/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721)
at ComponentNode.initiateRender (http://localhost:8071/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)"

@flotho

flotho commented Feb 11, 2025

Copy link
Copy Markdown
Member

Hello , I tried to migrate to version 17, but when I click on the pivot table icon, it shows me the following error: "UncaughtPromiseError > OwlError Uncaught Promise > An error occured in the owl lifecycle (see this Error's "cause" property) OwlError: An error occured in the owl lifecycle (see this Error's "cause" property) Error: An error occured in the owl lifecycle (see this Error's "cause" property) at handleError (http://localhost:8071/web/assets/debug/web.assets_web.js:9163:35) (/web/static/lib/owl/owl.js:1579) at App.handleError (http://localhost:8071/web/assets/debug/web.assets_web.js:13483:20) (/web/static/lib/owl/owl.js:5899) at Fiber._render (http://localhost:8071/web/assets/debug/web.assets_web.js:9316:30) (/web/static/lib/owl/owl.js:1732) at Fiber.render (http://localhost:8071/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721) at ComponentNode.initiateRender (http://localhost:8071/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)

Caused by: TypeError: ctx.getSpreadsheetInsertionTooltip is not a function at PivotRenderer.template (eval at compile (http://localhost:8071/web/assets/debug/web.assets_web.js:13198:20), :26:54) (/web/static/lib/owl/owl.js:5614) at App.callTemplate (http://localhost:8071/web/assets/debug/web.assets_web.js:10902:50) (/web/static/lib/owl/owl.js:3318) at PivotRenderer.template (eval at compile (http://localhost:8071/web/assets/debug/web.assets_web.js:13198:20), :27:10) (/web/static/lib/owl/owl.js:5614) at Fiber._render (http://localhost:8071/web/assets/debug/web.assets_web.js:9313:38) (/web/static/lib/owl/owl.js:1729) at Fiber.render (http://localhost:8071/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721) at ComponentNode.initiateRender (http://localhost:8071/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)"

same thing here in v17

@pedrobaeza

Copy link
Copy Markdown
Member

Superseded by #60

@pedrobaeza pedrobaeza closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.