[17.0][MIG] spreadsheet_oca by etobella · Pull Request #59 · OCA/spreadsheet

etobella · 2025-02-16T10:11:22Z

Finishes migration of #40

With this change we are adding an extra layer of security. Without it, any user was able to sniff how all happened using something like: const any_spreadsheet_id = 1234; const channel = "spreadsheet_oca;spreadsheet.spreadsheet;" + any_spreadsheet_id; bus_service.addChannel(channel); bus_service.addEventListener("spreadsheet_oca", (message) => /* every revision arrives here */ With the change, we verify the access to the model with a similar logic to `web_editor` fields

Fixes OCA#9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Currently translated at 100.0% (102 of 102 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

legalsylvain · 2025-02-16T20:03:09Z

Hi @etobella. Thanks for porting this module.
could you take a time to review this V16 pending PR #57.
So the last improvments could go in the last version.

thanks !

chrisandrewmann · 2025-02-16T20:46:02Z

Thanks @etobella.
I've done a quick test and all looks good, apart from a couple of localisation issues noticed (i'm based in the UK so using GBP currency).

In spreadsheet_oca on Community V16 (and V17 Enterprise), you are able go to "Format > Number > Custom currency", to set a currency other than USD.
This menu is missing currently, looking at the code it seems to be related to setting the locale?

On Enterprise you do it by going to File > Settings and changing the locale:

CarlosRoca13

Thanks @etobella! Can you execute pre-commit?

CarlosRoca13

When I tried to add a dynamic table from a pivot view I'm getting next error:

OwlError: The following error occurred in onWillStart: "row.map is not a function"
    Error
        at wrapError (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:10180:23) (/web/static/lib/owl/owl.js:2631)
        at onWillStart (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:10224:29) (/web/static/lib/owl/owl.js:2675)
        at SpreadsheetRenderer.setup (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:69959:5) (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_renderer.esm.js:89)
        at new ComponentNode (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:9928:28) (/web/static/lib/owl/owl.js:2379)
        at http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:13524:28 (/web/static/lib/owl/owl.js:5975)
        at ActionSpreadsheetOca.template (eval at compile (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:13248:20), <anonymous>:16:16) (/web/static/lib/owl/owl.js:5699)
        at Fiber._render (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:9278:38) (/web/static/lib/owl/owl.js:1729)
        at Fiber.render (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:9270:18) (/web/static/lib/owl/owl.js:1721)
        at ComponentNode.initiateRender (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/web.assets_web.js:9950:23) (/web/static/lib/owl/owl.js:2401)

Caused by: TypeError: row.map is not a function
    at http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:67186:24 (/spreadsheet/static/src/pivot/pivot_table.js:85)
    at Array.map (<anonymous>)
    at new SpreadsheetPivotTable (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:67182:27) (/spreadsheet/static/src/pivot/pivot_table.js:81)
    at PivotCorePlugin.handle (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:67828:31) (/spreadsheet/static/src/pivot/plugins/pivot_core_plugin.js:91)
    at Model.dispatchToHandlers (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:57848:25) (/spreadsheet/static/src/o_spreadsheet/o_spreadsheet.js:57731)
    at http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:57792:30 (/spreadsheet/static/src/o_spreadsheet/o_spreadsheet.js:57675)
    at StateObserver.recordChanges (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:55841:13) (/spreadsheet/static/src/o_spreadsheet/o_spreadsheet.js:55724)
    at Model.dispatch (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:57788:62) (/spreadsheet/static/src/o_spreadsheet/o_spreadsheet.js:57671)
    at ActionSpreadsheetOca.importDataPivot (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:70316:23) (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_action.esm.js:250)
    at async ActionSpreadsheetOca.importData (http://oca-spreadsheet-17-0-pr59-1b4cf23a9dc5.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:70333:7) (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_action.esm.js:267)

I have set next configuration to get the error:

chrisandrewmann · 2025-02-18T10:57:10Z

Ref #59 (comment)

I've got a working POC which fixes this. How do you want me to provide it? @etobella
In summary:

Adds the [Settings] menu item to the file menu, allowing user to change the locale
Sets the default currency format for new sheets based on the current company
Retrieves all locales and currencies
Enables the Format > Number > Custom Currency sidebar to select currencies
In addition i've been working on adding the ability to delete pivots and lists from the sheet.

etobella · 2025-02-18T11:01:24Z

Make a PR an I can review it

chrisandrewmann · 2025-02-18T11:19:58Z

Make a PR an I can review it

@etobella PR is here: dixmit#1

etobella · 2025-02-23T17:27:00Z

@CarlosRoca13 The error is related to some functionality that was added to limit the rows and columns. I fixed it for rows, but the same patch is not working for columns. I will investigate why 😢

Set default currency for new sheets. Fix crash on insertDynamicPivot. Fix typos (noficiation > notification). Add feature to delete pivots and lists from sheet via button on sidebars.

chrisandrewmann

Crashes when adding new chart to sheet

chrisandrewmann · 2025-03-04T13:33:45Z

+  get menuProps() {
+    const menu = this.env.model.getters.getChartOdooMenu(this.props.figureId);
+    var result = {
+      record: this.record,


Causes crash when adding a new chart to sheet.
Replace with fieldString: _t("Menu Items"),

chrisandrewmann · 2025-03-04T13:34:30Z

+import {Many2XAutocomplete} from "@web/views/fields/relational_utils";
+import {patch} from "@web/core/utils/patch";
+import {useService} from "@web/core/utils/hooks";
+


Add import {_t} from "@web/core/l10n/translation";

chrisandrewmann · 2025-03-04T13:35:22Z

+import {Domain} from "@web/core/domain";
+import {Many2XAutocomplete} from "@web/views/fields/relational_utils";
+import {useService} from "@web/core/utils/hooks";
+


Add import {_t} from "@web/core/l10n/translation";

chrisandrewmann · 2025-03-04T13:36:21Z

+  get menuProps() {
+    const menu = this.env.model.getters.getChartOdooMenu(this.props.figureId);
+    var result = {
+      record: this.record,


Causes crash when adding a new chart to sheet.
Replace with fieldString: _t("Menu Items"),

chrisandrewmann · 2025-03-04T17:22:20Z

+class SpreadsheetDownloadXLSX(Controller):
+    @route("/spreadsheet/xlsx", type="http", auth="user", methods=["POST"])
+    def download_spreadsheet_xlsx(self, zip_name, files, **kw):
+        files = json.loads(files)


Crashes when exporting to XLSX when filestorage object not JSON.

Add this line above:
if hasattr(files, "read"): files = files.read().decode("utf-8")

chrisandrewmann

Downloading XLSX crashes, small amendment to download_spreadsheet_xlsx

chrisandrewmann · 2025-03-31T14:27:45Z

@etobella I've been using the module on my own environment, using it daily to put it through it's paces, have had to make several other changes today, but i'm aware they are stacking up on this PR along with all my previous suggestions.
Would it be easier if I were to create a new PR based on your branch instead?

Not sure if you managed to fix the error that @CarlosRoca13 reported about rows/columns mapping?
I've not touched that part.

So far it's working really well, only area I'm not able to figure out is how to modernise the date filter to incorporate the V17 changes (From/To range and newly reworked fixed periods). But it's working fine as is for now.
Even managed to get spreadsheet_dashboard working with a small tweak.

pedrobaeza · 2025-03-31T14:29:05Z

Yes, please, supersede this PR creating one respecting the current work, and adding yours in top.

chrisandrewmann · 2025-03-31T14:31:46Z

Yes, please, supersede this PR creating one respecting the current work, and adding yours in top.

Thanks @pedrobaeza
I've never done this before, what's the best way to supercede the PR so it's clear?

pedrobaeza · 2025-03-31T14:34:12Z

Fetch this branch, add your changes on a commit on top, and push to your fork, proposing a new PR and mentioning this one.

pedrobaeza · 2025-04-04T17:49:35Z

Superseded by #60

etobella and others added 30 commits February 16, 2025 10:53

[ADD] spreadsheet_oca

35ccfbc

[UPD] Update spreadsheet_oca.pot

eab15d2

[UPD] README.rst

c50b879

[UPD] Update spreadsheet_oca.pot

165770d

spreadsheet_oca 16.0.1.0.1

ffa4a18

[IMP] spreadsheet_oca: Allow to import to existent spreadsheets

1b38858

[IMP] spreadsheet_oca: Allow to export graphs to spreadsheets

398ae32

[IMP] spreadsheet_oca: add to current sheet

b211f60

[UPD] Update spreadsheet_oca.pot

b0ee374

spreadsheet_oca 16.0.1.1.0

dff56d0

[FIX] spreadsheet_oca: Ctrl+Z was not working properly

631b4b3

[IMP] spreadhseet_oca: Allow edition of sheet name

8d6fc1c

[IMP] spreadsheet_oca: Allow to edit filters

b224cc6

[UPD] Update spreadsheet_oca.pot

69dd677

spreadsheet_oca 16.0.1.1.1

d477679

[UPD] Update spreadsheet_oca.pot

9a30157

[FIX] spreadsheet_oca: Filters where failing

b3f51dc

[IMP] spreadsheet_oca: Alloe to edit Pivot data

2e79c1a

[IMP] spreadsheet_oca: Allow to import lists

f3500ee

[IMP] spreadsheet_oca: Allow to edit lists

d0b5165

[IMP] spreadsheet_oca: Allow to reinsert a pivot table

62d545d

[FIX] spreadsheet_oca: Fix filters

169cd5a

[UPD] Update spreadsheet_oca.pot

aa20058

spreadsheet_oca 16.0.1.1.2

05efacf

[IMP] spreadsheet_oca: Allow to edit Odoo graphs properly

5c5df99

Fixes OCA#9

[UPD] Update spreadsheet_oca.pot

6ac4d05

spreadsheet_oca 16.0.1.1.3

c28ad8b

[UPD] Update spreadsheet_oca.pot

cf343b8

[IMP] spreadsheet_oca: Add roadmap for specific questions

3805eca

OCA-git-bot and others added 9 commits February 16, 2025 11:10

[BOT] post-merge updates

f6a83eb

[IMP] spreadsheet_oca: Allow to import XLSX Files

9114b84

[UPD] Update spreadsheet_oca.pot

6afe4b5

[BOT] post-merge updates

510b04c

Update translation files

da8d62b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Translated using Weblate (Italian)

5a7b08c

Currently translated at 100.0% (102 of 102 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

[IMP] spreadsheet_oca: pre-commit auto fixes

c509e2e

[MIG] spreadsheet_oca: Migration to 17.0

f99ac01

[MIG] spreadsheet_oca: Continue migration

1b4cf23

CarlosRoca13 reviewed Feb 17, 2025

View reviewed changes

CarlosRoca13 requested changes Feb 17, 2025

View reviewed changes

[IMP] spreadsheet_oca: Add support for changing locale and currencies.

8ace503

Set default currency for new sheets. Fix crash on insertDynamicPivot. Fix typos (noficiation > notification). Add feature to delete pivots and lists from sheet via button on sidebars.

etobella force-pushed the 17.0-mig-spreadsheet branch from 198dfad to 8ace503 Compare February 23, 2025 17:33

[FIX] spreadsheet_oca: Fix when using dynamic number of rows & columns

872b106

chrisandrewmann suggested changes Mar 4, 2025

View reviewed changes

chrisandrewmann reviewed Mar 4, 2025

View reviewed changes

chrisandrewmann suggested changes Mar 4, 2025

View reviewed changes

chrisandrewmann mentioned this pull request Apr 3, 2025

[17.0][MIG] spreadsheet_oca: Migration to 17.0 #60

Merged

pedrobaeza closed this Apr 4, 2025

Uh oh!

Conversation

etobella commented Feb 16, 2025

Uh oh!

legalsylvain commented Feb 16, 2025

Uh oh!

chrisandrewmann commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etobella commented Feb 18, 2025

Uh oh!

chrisandrewmann commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etobella commented Feb 23, 2025

Uh oh!

chrisandrewmann left a comment

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann left a comment

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Mar 31, 2025

Uh oh!

chrisandrewmann commented Mar 31, 2025

Uh oh!

pedrobaeza commented Mar 31, 2025

Uh oh!

pedrobaeza commented Apr 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

chrisandrewmann commented Feb 16, 2025 •

edited

Loading

chrisandrewmann commented Feb 18, 2025 •

edited

Loading

chrisandrewmann commented Feb 18, 2025 •

edited

Loading

chrisandrewmann commented Mar 31, 2025 •

edited

Loading