Conversation
…reviews' name and state correctly translated.
* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.
Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/zh_CN/
notification to possible reviewers.
* fix test after the last forward-ported feature. * add a descrition of new know issue.
… rebranding of Eficent to ForgeFlow.
…tified. A customer or supplier can be a follower of the object and should not receive internal messages about the tier validation.
Currently translated at 100.0% (74 of 74 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/zh_CN/
Currently translated at 80.0% (60 of 75 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/es/
…urchase modules installed
jguenat
left a comment
There was a problem hiding this comment.
Remove 18.0.X migration scripts
|
orignally posted at #3 but i think it belongs here:
|
Co-authored-by: Eugene Molotov <molotov@it-projects.info>
bb9d12b to
94211ee
Compare
Will check that later |
|
@jguenat Your change request seems to be resolved. Can you please check again ? |
santostelmo
left a comment
There was a problem hiding this comment.
@em230418 do you have a moment to check this point ?
#1 (comment)
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Could you include the recent patches done in 18.0?
|
Just noticed a new feature. Steps to reproduce: |
bosd
left a comment
There was a problem hiding this comment.
Functional review:
Issue: Sequential approval notifications sent to all followers instead of only the pending reviewer
When using approve_sequence=True with notify_on_create=False and notify_on_pending=True, the sequential notification logic correctly
transitions only the first review to "pending" status. However, the actual notification reaches all followers of the record, not just the
intended reviewer.
The issue is in _notify_review_available() in tier_validation.py:
def _notify_review_available(self, tier_reviews):
...
rec.message_subscribe(
partner_ids=users_to_notify.mapped("partner_id").ids
)
rec.message_post(
subtype_xmlid=self._get_requested_notification_subtype(),
body=rec._notify_requested_review_body(),
)
message_subscribe() is called without subtype_ids (subscribing with all default subtypes), and then message_post() sends a notification to
all followers of the record — not just the reviewer whose tier just became pending.
This means if the second approver is already a follower (e.g. they created the record, or were auto-subscribed), they receive the
notification at the same time as the first approver, defeating the purpose of sequential approval.
Expected behavior: Only the reviewer whose tier transitions to "pending" should be notified. The second reviewer should only be notified
after the first reviewer approves.
Possible fix: Use a targeted notification (e.g. message_notify()) instead of message_post(), so that only the specific reviewer is
notified rather than all followers.
|
@bosd coulyou check if fix is working as expected? |
|
More improvements in 18.0 OCA/server-ux#1246 |
|
As for now I am busy with other projects. Feel free to recreate PR based on this. |
No description provided.