[MIG] purchase_tier_validation: Migration to 19.0

[jaydeep32]

No description provided.

[bosd]

Can you please fix the tests by adding the test requirements?

[jaydeep32]

Yes, sure, but I have never done that before, so do you have any possible examples or guidelines on what and how to add?
And a possible file structure as well.

[bosd]

@jaydeep32 Sure, I need to peek at other PR's how to do it all the time :)

Basically you need to add in the root of the repo folder a test-requirements.txt file.
If you want to depend on PR #1
The content should be:

odoo-addon-base_tier_validation @ git+https://github.com/OCA/tier-validation@refs/pull/1/head#subdirectory=base_tier_validation

I'll typically commit it in a separate commit "[DO NOT MERGE TEST REQUIREMENTS]"

Result:
OCB & Odoo tests should pass,
Runboat build finishes (So one can easily functional test this)
Red marker displayed about unreleased dependencies

source: https://github.com/OCA/oca-custom/blob/18.0/CONTRIBUTING.md#use-unreleased-dependency

Can you please update and apply this to your other pr's in this repo? 😉

[bosd]

Can you please squash the administrative translation commits?

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Then this one is good to go 👍

[nurinayati]

Please see the missing functional part below, The requested by should be filled by the requested user and The Done by should be the reviewer. thank you

[bosd]

Please see the missing functional part below, The requested by should be filled by the requested user and The Done by should be the reviewer. thank you

I noticed this in the account_move_tier_validation module as well. I think this should be fixed in the base module.
I hope this is fixed in the most recent pr #15

[bosd]

LGTM

[santostelmo]

@jaydeep32 dependency was merged. Can you please drop it and trigger CI again ?

[rven]

Suggested change

	domain="[('validated', '=', True)]"
	domain="[('validation_status', '=', 'validated')]"

[jaydeep32]

Thanks for the update. I have updated code as per this.

[LoisRForgeFlow]

@jaydeep32 can you remove this temporal commit? The base modules is merged, thanks!

[jaydeep32]

I have removed this commit

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[santostelmo]

@LoisRForgeFlow are we good to trigger merge ?

[LoisRForgeFlow]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-7-by-LoisRForgeFlow-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 8342084. Thanks a lot for contributing to OCA. ❤️