[10.0][ADD][web_chatter_paste]

[tarteo]

This module makes it easier to upload attachments while composing a message (chatter).

Paste an image (e.g. a screenshot) or drop any file into the composer and it will be automatically added as attachment.

Browser support:

• Dropping files only works in Chrome.

[JordiBForgeFlow]

Thanks @mreficent @lreficent can you review? It osnfor v10

[tarteo]

Can somebody help me with the tests? I don't know how to make tests for controllers.

[LoisRForgeFlow]

Tested on runbot, I can attach both ways but when sending the message it is not actually sent. I don't know if this is a runbot problem though.

[pedrobaeza]

Hi, why this doesn't work on all the browsers (or Firefox mainly)? Is this not working also on mobiles (the paste option, of course)?

[tarteo]

@lreficent This is an issue of runbot. I installed the module on a fresh environment and it worked.

[tarteo]

@pedrobaeza I made a mistake. It actually works for Firefox, but only for Gecko version 50 or higher.

https://developer.mozilla.org/nl/docs/Web/API/DataTransferItem

[LoisRForgeFlow]

Tested on local with Firefox and Chromium 👍

[lasley]

@tarteo - Regarding the controller tests, what kind of issues were you running into? Looking at this controller, it could be something simple like:

res = ChatterPasteController().upload_attachment(..)
self.assertDictEqual(res, expected)
self.assertTrue(
    self.env['ir.attachment'].browse(res['id']),
)

[tarteo]

@lasley I don't remember anymore... haha. Thanks though! I will make the tests asap.

[tarteo]

@lasley I don't understand why my tests are not working. It works on my development machine.

ERROR: test_controller (odoo.addons.web_chatter_paste.tests.test_web_chatter_paste.TestWebChatterPaste)
Traceback (most recent call last):
File "/home/travis/build/OCA/web/web_chatter_paste/tests/test_web_chatter_paste.py", line 14, in test_controller attachment_obj = self.env['ir.attachment'].with_env(request.env)
File "/home/travis/.local/lib/python2.7/site-packages/werkzeug/local.py", line 343, in __getattr__ return getattr(self._get_current_object(), name)
File "/home/travis/.local/lib/python2.7/site-packages/werkzeug/local.py", line 302, in _get_current_object return self.__local()
File "/home/travis/.local/lib/python2.7/site-packages/werkzeug/local.py", line 135, in _lookup raise RuntimeError('object unbound')
` RuntimeError: object unbound
FAILED
Module web_chatter_paste: 0 failures, 1 errors
At least one test failed when loading the modules.
Modules loaded message not found.

Can you help me please?

[tarteo]

Tests are working locally but not here. Is this a known problem?

[lasley]

@tarteo - sorry I missed your last comment. Hrmmm it's working on Runbot too. I honestly have no idea, maybe try a rebase on 10.0? This totally looks like something glitchy, and not something your end - I'm not even able to load the Travis build.

[tarteo]

@lasley I've made it work using 'MagicMock' https://docs.python.org/3/library/unittest.mock.html 😄

[lasley]

This is not correctly unpatching. You should mock using with statements & patching like so:

with mock.patch.object(http, 'request') as request:
    request.env = self.env
    ....

Not doing this will leave the request object as a mock in the http module. This will then affect subsequent tests if they require a request.

[tarteo]

Oh I didn't know that. Thanks I'll fix it.

[tarteo]

@lasley fixed it

[lasley]

Thanks @tarteo

[pedrobaeza]

Is this comment outdated now?