Closed
Conversation
Member
Author
|
Tests are working locally but not here (same issue as in OCA/web#548) |
simahawk
reviewed
Mar 21, 2017
| events = event_obj.search([('start', '<', select_stop), | ||
| ('stop', '>', select_start)]) | ||
| request = http.request | ||
| http.request = MagicMock(env=self.env, |
There was a problem hiding this comment.
check Dave's comment in OCA/web/pull/548. You should use a context manager.
simahawk
reviewed
Mar 21, 2017
|
|
||
| //Mutate data for calendar | ||
| var events = result.events; | ||
| for(var i = 0; i < events.length; i++) { |
There was a problem hiding this comment.
what about moving this to specific function? Something like prepare_events would ease customization.
simahawk
requested changes
Mar 21, 2017
| ================ | ||
|
|
||
| This module adds a new block in the website editor. | ||
| The new block is based on Calendar (module). Use field 'Privacy' |
Member
Author
There was a problem hiding this comment.
No, I mean the calendar of Odoo module 'Calendar'.
astirpe
approved these changes
Jul 28, 2017
astirpe
left a comment
Member
There was a problem hiding this comment.
Only a minor fix in the readme, other than that it LGTM
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues | ||
| <https://github.com/OCA/186/issues>`_. In case of trouble, please |
Member
|
Branch rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously (branch 8.0) the name was 'website_calendar_snippet'