[MIG][10.0] website_form_recaptcha - #267
Merged
Merged
Conversation
1 task
Contributor
Author
|
This has been fixed & is ready for review. Functional review can take place in #268 |
pedrobaeza
approved these changes
Nov 12, 2016
Contributor
Author
|
@tedsalmon please review |
simahawk
approved these changes
Mar 21, 2017
simahawk
left a comment
There was a problem hiding this comment.
LGTM despite a small issue w/ JS indentation
| url: '/website/recaptcha/', | ||
| method: 'GET', | ||
| success: function(data){ | ||
| data = JSON.parse(data); |
* Update website_form_recaptcha to v10
lasley
force-pushed
the
release/10.0/website_form_recaptcha
branch
from
March 28, 2017 17:48
9c9a9ea to
5e7afaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was theoretically as simple as changing the version numbers. I would like a functional test though, so WIP until my PR on website_crm_recaptcha so that we may confirm the base works.